✨ Allow SVG 'focusable' attribute from SVG Tiny 1.2#19128
Merged
Gregable merged 1 commit intoampproject:masterfrom Nov 6, 2018
Merged
✨ Allow SVG 'focusable' attribute from SVG Tiny 1.2#19128Gregable merged 1 commit intoampproject:masterfrom
Gregable merged 1 commit intoampproject:masterfrom
Conversation
6 tasks
Contributor
|
(added |
Member
|
LGTM. |
|
Thanks for fixing. Do we know when the new version is likely to be published? Last release was 9 months ago: https://www.npmjs.com/package/amphtml-validator |
Contributor
|
@ChrisBAshton about 1-2 weeks. The publish date of https://www.npmjs.com/package/amphtml-validator is not representative since rules are fetched dynamically. |
alin04
pushed a commit
to alin04/amphtml
that referenced
this pull request
Nov 13, 2018
Merged
alin04
added a commit
that referenced
this pull request
Nov 13, 2018
* cl/220306609 Revision bump for #17907 * cl/220307253 Revision bump for #19128 * cl/220310523 Revision bump for #19129 * cl/220399983 Revision bump for #19167 * cl/221145203 n/a * cl/221159765 Revision bump for #19214 * cl/221164382 Invalidate `<amp-script>` tag as well * cl/221176616 Revision bump for #17939 * cl/221181356 Revision bump for #19171
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* cl/220306609 Revision bump for ampproject#17907 * cl/220307253 Revision bump for ampproject#19128 * cl/220310523 Revision bump for ampproject#19129 * cl/220399983 Revision bump for ampproject#19167 * cl/221145203 n/a * cl/221159765 Revision bump for ampproject#19214 * cl/221164382 Invalidate `<amp-script>` tag as well * cl/221176616 Revision bump for ampproject#17939 * cl/221181356 Revision bump for ampproject#19171
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In working on adding AMP compatibility to the next default WordPress theme Twenty Nineteen (ampproject/amp-wp#1587), I found that it was outputting a
focusableattribute in ansvgelement like so:The
focusableattribute is defined in SVG Tiny 1.2: https://www.w3.org/TR/SVGTiny12/interact.html#focusable-attrFixes #19107
/cc @Gregable