🐛Add date-template and info-template to amp-date-picker validation.#15106
Merged
cvializ merged 2 commits intoampproject:masterfrom May 7, 2018
Merged
🐛Add date-template and info-template to amp-date-picker validation.#15106cvializ merged 2 commits intoampproject:masterfrom
cvializ merged 2 commits intoampproject:masterfrom
Conversation
honeybadgerdontcare
requested changes
May 7, 2018
| } | ||
| } | ||
|
|
||
| # HTML5, 4.11.3 The template element |
Contributor
There was a problem hiding this comment.
The template tag is defined in the amp-mustache extension as well. Please add a comment here noting that and also there noting these are defined here. See https://github.com/ampproject/amphtml/blob/master/extensions/amp-mustache/validator-amp-mustache.protoascii
| spec_name: "amp-date-picker > template [date-template] [dates]" | ||
| mandatory_parent: "AMP-DATE-PICKER" | ||
| requires_extension: "amp-mustache" | ||
| attrs: { |
Contributor
There was a problem hiding this comment.
Please alphabetize by attribute name (here and below).
| } | ||
| } | ||
|
|
||
| # HTML5, 4.11.3 The template element |
Contributor
There was a problem hiding this comment.
no need to repeat this comment or have blank lines between tags: {}
Contributor
Author
|
Thanks for the review! PTAL |
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
May 10, 2018
…mpproject#15106) * Add date-template and info-tempalte to amp-date-picker validation. * Cleanup validator protoascii with review feedback
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were missing, making the date picker example on amp-by-example invalid.