✅ Add validation for rotate-to-fullscreen in amp-video#14969
Merged
alanorozco merged 2 commits intoampproject:masterfrom May 1, 2018
Merged
✅ Add validation for rotate-to-fullscreen in amp-video#14969alanorozco merged 2 commits intoampproject:masterfrom
alanorozco merged 2 commits intoampproject:masterfrom
Conversation
aghassemi
approved these changes
Apr 30, 2018
Member
Author
|
@aghassemi done. |
honeybadgerdontcare
approved these changes
Apr 30, 2018
Contributor
|
|
f3eb0bd to
3671ca1
Compare
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
May 10, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding only for
amp-videoas audit for support in other players is pending.