Reinstitute the check to make sure yarn.lock is updated with package.json#10781
Merged
rsimha merged 5 commits intoampproject:masterfrom Aug 3, 2017
rsimha:2017-08-03-Yarn
Merged
Reinstitute the check to make sure yarn.lock is updated with package.json#10781rsimha merged 5 commits intoampproject:masterfrom rsimha:2017-08-03-Yarn
rsimha merged 5 commits intoampproject:masterfrom
rsimha:2017-08-03-Yarn
Conversation
Contributor
Author
|
/to @erwinmombay |
Contributor
Author
|
Here is an example of This is now ready for review. |
Contributor
Author
|
/to @choumx |
erwinmombay
approved these changes
Aug 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure
yarn.lockis updated whenpackage.jsonis updated. The reverse check is not necessary because it's legitimate to updateyarn.lockwithout touchingpackage.jsonwhile bringing theyarninstall on Travis up to date.Fixes #10673
Related to #10671