Update yarn.lock and use node 6.0 on Travis#10671
Update yarn.lock and use node 6.0 on Travis#10671rsimha wants to merge 3 commits intoampproject:masterfrom rsimha:2017-07-24-YarnLock
Conversation
|
@erwinmombay, this is currently failing because we now depend on Edit: Upgraded the node version on Travis from 4.0 to 6.0 |
|
@jridgewell, was there an issue associated with #9575? Can you remind me of why this was necessary? I'm seeing a bunch of errors on Travis while updating |
|
Latest commit worked. We now need node 6.0 on Travis. This is ready for review. |
| dist: trusty | ||
| node_js: | ||
| - "4" | ||
| - "6" |
There was a problem hiding this comment.
We support the latest LTS, because it's used everywhere.
There was a problem hiding this comment.
I know what an LTS is, but don't understand what this means for our repository, or what Erwin's thumbs up means :)
Do we want to stick with node 4.0? This means that yarn.lock will be permanently out of date, given that we cannot update it until we move off of node 4.0. Is that acceptable? Won't new committers run into dependency problems while developing because yarn.lock is out of date?
There was a problem hiding this comment.
This is now blocking #10776 due to fetch-mock being incompatible with node 4. See https://travis-ci.org/ampproject/amphtml/jobs/260683377
Using node 6 for testing on Travis solves these issues.
There was a problem hiding this comment.
Thanks for linking that @rsimha-amp
There was a problem hiding this comment.
can you also update package.json engine version
There was a problem hiding this comment.
nevermind just read your latest comment :)
There was a problem hiding this comment.
@erwinmombay, I've sent you #10781 to detect issues like this in future.
|
/to @choumx for review |
|
Turns out that after a week of hacking at this, we must run |
@Raphaeljunior is running into issues with missing dependencies on his linux machine, and when I was helping him debug, I noticed that running
yarn upgrade --save-devresulted in a lot of updates toyarn.lock. It probably makes sense to check this in./to @erwinmombay for review / comment.
Fixes #10673