Skip to content

Allow test in Test_AMP_Core_Block_Handler to run now that WordPress/gutenberg#25026 has been merged#5347

Merged
westonruter merged 1 commit intodevelopfrom
remove-skipped-mark-test
Sep 7, 2020
Merged

Allow test in Test_AMP_Core_Block_Handler to run now that WordPress/gutenberg#25026 has been merged#5347
westonruter merged 1 commit intodevelopfrom
remove-skipped-mark-test

Conversation

@pierlon
Copy link
Copy Markdown
Contributor

@pierlon pierlon commented Sep 7, 2020

Summary

Now that WordPress/gutenberg#25026 has been merged, we can unmark Test_AMP_Core_Block_Handler::test_register_and_unregister_embed as being skipped when Gutenberg v8.9.0 or v8.9.1 is used.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@pierlon pierlon added Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs WS:Core Work stream for Plugin core labels Sep 7, 2020
@pierlon pierlon added this to the v2.0.2 milestone Sep 7, 2020
@pierlon pierlon requested a review from westonruter September 7, 2020 17:14
@pierlon pierlon self-assigned this Sep 7, 2020
@google-cla google-cla bot added the cla: yes Signed the Google CLA label Sep 7, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 7, 2020

Plugin builds for f845c4e are ready 🛎️!

@westonruter westonruter merged commit cb0f610 into develop Sep 7, 2020
@westonruter westonruter deleted the remove-skipped-mark-test branch September 7, 2020 20:26
westonruter pushed a commit that referenced this pull request Sep 7, 2020
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelogged Whether the issue/PR has been added to release notes. cla: yes Signed the Google CLA Testing Issues related with Unit, E2E, Smoke, and other testing requirements/needs WS:Core Work stream for Plugin core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants