Description

Unit tests for the AMP plugin started failing once Guenberg v8.9.0: ampproject/amp-wp#5319 (comment). The issue was traced back to 7fbdda2 as part of #25020.

Currently, when a Categories block is added and the "Display as dropdown" option is enabled, selecting a category in the dropdown has no effect. This is because the script constructed by build_dropdown_script_block_core_categories() is no longer making it into the page. The reason is that gutenberg_render_block_core_categories() is appending the script to the $wrapper_markup so it is outside of the block wrapper, but after 7fbdda2 only the block wrapper ($block_root) is returned by gutenberg_apply_block_supports().

This PR fixes that problem by ensuring that <script> returned by build_dropdown_script_block_core_categories() is inserted immediately after the </select> closing tag and is placed on the inside of the $items_markup rather than being inserted after the $wrapper_markup.

This should also prevent the sprintf() call from failing if someone has a category containing string formats.

How has this been tested?

Add a Categories block to the content and enable the "Display as dropdown" option. Before this PR, no <script> is added with the block. With this PR, a <script> is added and selecting a category causes navigation to the category.

Screenshots

Before

<div class="wp-block-categories-dropdown wp-block-categories">
	<select name="cat" id="wp-block-categories-1" class="postform">
		<option value="-1">Select Category</option>
		<option class="level-0" value="3">aciform</option>
		<!-- ... -->
	</select>
</div>

After

<div class="wp-block-categories-dropdown wp-block-categories">
	<select name="cat" id="wp-block-categories-1" class="postform">
		<option value="-1">Select Category</option>
		<option class="level-0" value="3">aciform</option>
		<!-- ... -->
	</select>
	<script type="text/javascript">
	/* <![CDATA[ */
	( function() {
		var dropdown = document.getElementById( 'wp-block-categories-1' );
		function onCatChange() {
			if ( dropdown.options[ dropdown.selectedIndex ].value > 0 ) {
				location.href = "https://wordpressdev.lndo.site/?cat=" + dropdown.options[ dropdown.selectedIndex ].value;
			}
		}
		dropdown.onchange = onCatChange;
	})();
	/* ]]&gt; */
	</script>
</div>

Types of changes

Bug fix (a regression)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.