Conversation
59901f4 to
634aae1
Compare
c8f1604 to
e7f39f2
Compare
e7f39f2 to
7658ab2
Compare
* Use "new" instead of "unseen" * Add AMP enabled/disabled to validated URLs list * Add new error count to validated URLs list
924571a to
7bfe06e
Compare
…orange info * Combine the Standard and Transitional disabled states into one. * Eliminate separate New count for validation errors, instead showing tooltip. * Bold the AMP enabled/disabled line.
…brand-validation-errors * 'develop' of github.com:ampproject/amp-wp: Update dependency postcss to v7.0.21 (#3625) Update dependency eslint-plugin-jest to v22.21.0 (#3631) Improve logic for merging meta amp-script-src elements Add todo note for AMP4EMAIL and explain base64url Improve test_prepare_response_for_amp_script Add tests for new elements and attributes Add support for inline amp-script, with hash generator and amp-script-src meta tag merging Exclude erroneous AMP4EMAIL specs which include (erroneously?) html_format=AMP Update allowed tags/attributes from spec in amphtml 1910161528000
| self::VALIDATION_ERROR_ACCEPT_ACTION | ||
| ), | ||
| esc_html( | ||
| self::VALIDATION_ERROR_NEW_ACCEPTED_STATUS === $sanitization['term_status'] ? __( 'Confirm remove', 'amp' ) : __( 'Remove', 'amp' ) |
There was a problem hiding this comment.
Should this be Confirm Removal? Feels more 'English' to me. But not a native speaker.
There was a problem hiding this comment.
That is my gut sense as well. Nevertheless, I can't think of a similar word for “keep”, so that's why I left it as a bare verb. “Confirm keepal” doesn't work.
There was a problem hiding this comment.
Maybe “Confirm removed” and “Confirm kept” would be better.
There was a problem hiding this comment.
Yes, I think so, because “confirm removed” has more or a sense that an action has been performed, whereas “confirm removal” has more of a timeless sense. And using the past participle means we can use “confirm kept”, and be consistent with other places we use the past participles in the markup status dropdowns.
Reduce size of AMP icon
Updates on Validated URL status metaboxAn explanation is added when there are AMP is disabled: And when AMP is enabled while there is invalid markup being removed, another message is displayed: When there is no invalid markup on the URL, then no message is required: AMP Validated URLs listThe “AMP enabled” and “AMP disabled” lines are removed from the validated URLs list, and “Status” column is changed to “Markup Status” to match the other screens: The icons are reduced in size. |
|
These changes are superb as they make the functionality of the plugin much more accessible, making it easier for developers to follow an AMP debugging workflow fully integrated with WordPress content generation mechanisms. |
…brand-validation-errors * 'develop' of github.com:ampproject/amp-wp: Update dependency @wordpress/core-data to v2.7.4 (#3640) Update dependency @wordpress/editor to v9.7.4 (#3641) If text has been pasted, also force update dimesisions. Update dependency @wordpress/api-fetch to v3.6.4 (#3639) Update dependency @wordpress/edit-post to v3.8.4 (#3643) Update eslint and eslint-plugin-jest (#3636) Fix context menu for RTL users. (#3633) Fix cross-page element dragging in RTL (#3637)




Summary
Fixes #2023.
Validated URLs List
Validation Error Index
Validation Error Detail
Validated URL with Kept Markup (Rejected Error)
Validated URL with Errors in all 4 states
Improvement to sources summary
Previously when there was a validation error occurring in the content, the summary would show:
Now, however, a translatable “Content” label is used:
And, more importantly, when there is more specific information available, like the block name, it is used instead:
Additionally, if Gutenberg is one of the sources, it will be suppressed since it should be considered the same as core.
Checklist