-
Notifications
You must be signed in to change notification settings - Fork 382
Description
The AMP plugin functionality is centered around interactions between actions taken by the plugin and actions taken by the user. The plugin can be configured to detect validation errors and automatically remove them (automatic sanitization). Or it can be configured to only detect errors but not removing them (manual sanitization). The user/developer has the control of what to do with detected errors. He/she can accept the plugin action (remove/not remove), or he/she can reject the plugin action.
This dicothomy between plugin and user actions percolates to the compatibility tool, and it is a main source of confusion for users of the plugin. This manifests in the labeling of errors that are surfaced by the compatibility tool as New Accepted or New Rejected, and the labeling of errors after the user has taken an action: Accepted or Rejected.
The problem is that the plugin actions are Remove and Keep (referring to the fate of the offending markup causing an error), while the user action is Accept or Reject (referring to the user intention with respect to the plugin action).
To remove this confusion, the compatibility tool should label the errors according to the action of the plugin, and not according to the action of the user. This entails updating the error labels this way:
New AcceptedtoNew, RemovedNew RejectedtoNew, KeptAcceptedtoRemovedRejectedtoKept
This is only a change in labels and internal resource labeling.