Fix cross-page element dragging in RTL#3637
Merged
swissspidy merged 2 commits intodevelopfrom Oct 28, 2019
Merged
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
As discovered in #3634 block dragging across pages doesn't work in RTL as the moved element is offset by several pages on the new page. This is fixed by changed the direction of the offsetting based off of RTL setting. _Fixes 3634. Fixes 3012._
046f221 to
2871e4f
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
swissspidy
reviewed
Oct 28, 2019
swissspidy
approved these changes
Oct 28, 2019
spacedmonkey
approved these changes
Oct 28, 2019
westonruter
added a commit
that referenced
this pull request
Oct 28, 2019
…brand-validation-errors * 'develop' of github.com:ampproject/amp-wp: Update dependency @wordpress/core-data to v2.7.4 (#3640) Update dependency @wordpress/editor to v9.7.4 (#3641) If text has been pasted, also force update dimesisions. Update dependency @wordpress/api-fetch to v3.6.4 (#3639) Update dependency @wordpress/edit-post to v3.8.4 (#3643) Update eslint and eslint-plugin-jest (#3636) Fix context menu for RTL users. (#3633) Fix cross-page element dragging in RTL (#3637)
westonruter
added a commit
that referenced
this pull request
Oct 28, 2019
…amp-to-amp-navigation * 'develop' of github.com:ampproject/amp-wp: (74 commits) Update button dimensions in CTA edit component Update snackbar message wording when removing duplicated blocks (#3652) Use 'Confirm removed' and 'Confirm kept' Improve presentation of enabled/disabled AMP Improve vertical alignment of image next to markup status dropdown Update dependency @wordpress/core-data to v2.7.4 (#3640) Update dependency @wordpress/editor to v9.7.4 (#3641) If text has been pasted, also force update dimesisions. Update dependency @wordpress/api-fetch to v3.6.4 (#3639) Update dependency @wordpress/edit-post to v3.8.4 (#3643) Update eslint and eslint-plugin-jest (#3636) Fix context menu for RTL users. (#3633) Fix cross-page element dragging in RTL (#3637) Ensure update notice is only shown after an update; update todo comment; simplify logic Ensure update notice is shown upon update even if no changes were made Remove obsolete SVGs Colorize remove/keep buttons Improve page heading for validated URL screen Fix display of status icon in heading Set the heading of Validated URL screen to be just 'AMP Validated URL' ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discovered in #3634 block dragging across pages doesn't work in RTL as the moved element is offset by several pages on the new page. This is fixed by changing the direction of the offsetting based off of RTL setting.
Fixes #3634. Fixes #3012.
Checklist