Closed
Conversation
barklund
reviewed
Sep 27, 2019
barklund
reviewed
Sep 27, 2019
| getBlocksByClientId, | ||
| getAdjacentBlockClientId, | ||
| } = select( 'core/block-editor' ); | ||
| const { getCurrentPage, isReordering: _isReordering } = select( 'amp/story' ); |
Contributor
There was a problem hiding this comment.
Yeah, this is a common annoying problem. What's a good name for a boolean-returning function that doesn't clash with the name of the variable holding the result of said function?
Collaborator
Author
There was a problem hiding this comment.
Good question. To avoid it we could also just use select( 'amp/story' ).isReordering().
barklund
reviewed
Sep 27, 2019
barklund
reviewed
Sep 27, 2019
barklund
reviewed
Sep 27, 2019
barklund
reviewed
Sep 27, 2019
barklund
reviewed
Sep 27, 2019
barklund
reviewed
Sep 27, 2019
barklund
reviewed
Sep 27, 2019
barklund
reviewed
Sep 27, 2019
Co-Authored-By: Morten Barklund <morten@barklund.dk>
barklund
reviewed
Sep 27, 2019
3 tasks
Collaborator
Author
|
Closing in favor of #3412. The block editor part can be extracted from this PR at some point in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes some experimental refactoring of dozens of components to a) make them functional ones and b) to leverage React hooks. It is largely untested, even though I haven't spot any issues so far.
This PR likely has to be split up as hooks cannot be used pre-WordPress 5.3 unless Gutenberg is active, which means they're currently guaranteed to work in the Stories editor, but not elsewhere.