Leverage React hooks in most areas of the stories editor#3412
Merged
swissspidy merged 3 commits intodevelopfrom Oct 4, 2019
Merged
Leverage React hooks in most areas of the stories editor#3412swissspidy merged 3 commits intodevelopfrom
swissspidy merged 3 commits intodevelopfrom
Conversation
Split out from #3359.
Contributor
|
Let mark this as draft and only merge it a week or two after 5.3 goes out. |
Collaborator
Author
|
The Stories editor currently has a hard requirement to use latest version of the Gutenberg plugin (or soon WordPress 5.3), so I don't see a reason for waiting. |
6 tasks
spacedmonkey
reviewed
Oct 4, 2019
spacedmonkey
approved these changes
Oct 4, 2019
Contributor
spacedmonkey
left a comment
There was a problem hiding this comment.
This is a refactor of code and has no functional changes. All the existing tests pass both e2e / unit test. Functional breaks should be spotted by QA. Tentatively approving this.
miina
reviewed
Oct 4, 2019
miina
reviewed
Oct 4, 2019
miina
reviewed
Oct 4, 2019
assets/src/stories-editor/blocks/amp-story-page-attachment/attachment-content.js
Show resolved
Hide resolved
miina
reviewed
Oct 4, 2019
assets/src/stories-editor/blocks/amp-story-page-attachment/attachment-content.js
Show resolved
Hide resolved
miina
reviewed
Oct 4, 2019
miina
reviewed
Oct 4, 2019
miina
reviewed
Oct 4, 2019
miina
reviewed
Oct 4, 2019
assets/src/stories-editor/blocks/amp-story-page/background-media-settings.js
Show resolved
Hide resolved
This was referenced Oct 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #2538.
Split out from #3359 to focus on the stories editor only for now.
Hooks cannot be used pre-WordPress 5.3 unless Gutenberg is active, which means they're currently only guaranteed to work in the Stories editor.
Doing this migration was very helpful for better seeing side effects in components and to simplify logic in them.
Checklist