Install includes to include/${PROJECT_NAME}#83
Merged
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Contributor
Author
audrow
approved these changes
Jan 10, 2022
Contributor
audrow
left a comment
There was a problem hiding this comment.
Looks good to me with green CI. Feel free to add me as a reviewer on the related PRs as they come out of draft state.
Contributor
Author
It looks like some of the packages will take longer, so I'll do CI with a repos file CI (repos file build:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ros2/ros2#1150
This installs includes to
include/${PROJECT_NAME}to mitigate include directory search order issues when overriding packages in desktop.Marked as draft because I'm opening a bunch of PRs at once to run CI all at the same time.