Skip to content

Extend API to use std::filesystem (backport #104)#109

Merged
ahcorde merged 2 commits intoament:jazzyfrom
peci1:backport_104_jazzy
Feb 2, 2026
Merged

Extend API to use std::filesystem (backport #104)#109
ahcorde merged 2 commits intoament:jazzyfrom
peci1:backport_104_jazzy

Conversation

@peci1
Copy link
Copy Markdown

@peci1 peci1 commented Jan 27, 2026

This is a manual backport of #104 to Jazzy.

I've decided to reimplement the new std::filesystem API using the old API to get consistent results and avoid code duplication. All tests for the std::filesystem API still pass. But if it's more suitable, I can also copy-paste the original std::filesystem implementations from #104.

ahcorde and others added 2 commits January 27, 2026 11:17
@ahcorde @peci1
Extend API to use std::filesystem (ament#104)
72480f8 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@peci1
Removed deprecations from std::string-based API (it is deprecated sin…
8c94282 
…ce Lyrical).

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
@peci1 peci1 force-pushed the backport_104_jazzy branch from 4653f05 to 8c94282 Compare January 27, 2026 10:17
@peci1 peci1 mentioned this pull request Jan 27, 2026
Merged
@peci1
Copy link
Copy Markdown
Author

peci1 commented Jan 27, 2026

Regarding ABI, there should be no change for the existing symbols (their implmentation has not been touched).

Regarding API, this PR pulls <filesystem>, <optional> and <utility> into some header files. I don't think this is a problem. No includes are removed.

@jmachowinski
Copy link
Copy Markdown

jmachowinski commented Jan 28, 2026 •
edited
Loading

Pulls: #109
Gist: https://gist.githubusercontent.com/jmachowinski/5b58c27483d75bce048032f3143ef34a/raw/a4c968146c6a2aa68360660cb746352837044e7e/ros2.repos
BUILD args:
TEST args:
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18058

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@peci1
Copy link
Copy Markdown
Author

peci1 commented Jan 28, 2026

@jmachowinski if you need to see green CI, please rerun Linux and Linux-rhel jobs. They were interrupted.

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Feb 2, 2026

Pulls: #109
Gist: https://gist.githubusercontent.com/ahcorde/468dd66373738fc90c3b1ea28629bc95/raw/a4c968146c6a2aa68360660cb746352837044e7e/ros2.repos
BUILD args: --packages-above-and-dependencies ament_index_cpp
TEST args: --packages-above ament_index_cpp
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18084

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 1bba98c into ament:jazzy Feb 2, 2026
3 checks passed
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Feb 2, 2026

https://github.com/Mergifyio backport kilted humble

@mergify
Copy link
Copy Markdown

mergify bot commented Feb 2, 2026 •
edited
Loading

backport kilted humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Feb 2, 2026
@peci1 @ahcorde @mergify
Extend API to use std::filesystem (backport #104) (#109)
32e3d88 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 1bba98c)
@mergify mergify bot mentioned this pull request Feb 2, 2026
Merged
mergify bot pushed a commit that referenced this pull request Feb 2, 2026
@peci1 @ahcorde @mergify
Extend API to use std::filesystem (backport #104) (#109)
e4431ad 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 1bba98c)
@mergify mergify bot mentioned this pull request Feb 2, 2026
Closed
ahcorde added a commit that referenced this pull request Feb 3, 2026
@mergify @peci1 @ahcorde
Extend API to use std::filesystem (backport #104) (#109) (#110)
343a853 
(cherry picked from commit 1bba98c)

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
Co-authored-by: Martin Pecka <peci1@seznam.cz>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

+1 more reviewer

@jmachowinski jmachowinski jmachowinski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peci1 @jmachowinski @ahcorde