Handle non-library tokens in _LIBRARIES.#248
Merged
dirk-thomas merged 2 commits intomasterfrom Apr 23, 2020
Merged
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Author
|
CI up to
|
dirk-thomas
reviewed
Apr 23, 2020
ament_cmake_target_dependencies/cmake/ament_target_dependencies.cmake
Outdated
Show resolved
Hide resolved
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
dirk-thomas
approved these changes
Apr 23, 2020
Contributor
|
👍 to merge without CI. |
|
+1 Can the presence of compilation/linking flags in |
j-rivero
approved these changes
Apr 23, 2020
Contributor
No, because some package do pass those through Also there hasn't been a warning for this in the past so we shouldn't introduce one now and here. |
j-rivero
pushed a commit
that referenced
this pull request
Apr 27, 2020
* Handle non-library tokens in _LIBRARIES. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Drop spaces on clauses. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up quickly to fix https://ci.ros2.org/job/ci_linux/10438. Connext seems to be passing
target_link_libraries()keywords likeoptimizedand linker flags like-Wl,--no-as-neededvia_LIBRARIES. That, coupled with a non-empty_LIBRARY_DIRS, makes added existence checks in #245 fail.I'm almost sure this is the right fix (at least for the short term).