Potential fix for fm_renumber and radios bug#658
Conversation
|
The While that doesn't really reduce the "overhead" of the change (and might even increase the overhead because we need to make sure Underscore loads before |
|
Confirming that this branch does fix the issue for us! 🥇 |
…o-renumber [Upstream PR alleyinteractive#658] Potential fix for fm_renumber and radios bug
|
It works for us too! Thank you. |
|
This fix worked for me! Can we get this merged? |
|
While it might be more overhead than ideal in theory (or might not), in practice there are many testimonials to it working, and no new approaches have been presented, so I think we can move ahead. We can always improve its performance in future PRs. |
A proposed solution to the bug reported in #548, this code modifies
fm_renumber()by adding a temporary and unique prefix to all modified field names during the renumbering process, then removes that prefix after renumbering is done.I'm not sold on this approach, it feels like a lot of overhead.
Closes #548