Skip to content

[Upstream PR #658] Potential fix for fm_renumber and radios bug#4

Merged
astratagem merged 2 commits intospiritedmediafrom
montchr-upstream-pr-658-radio-renumber
Jul 31, 2018
Merged

[Upstream PR #658] Potential fix for fm_renumber and radios bug#4
astratagem merged 2 commits intospiritedmediafrom
montchr-upstream-pr-658-radio-renumber

Conversation

@astratagem
Copy link
Copy Markdown

Cherry-picked version of alleyinteractive#658

Fixes the issue described in alleyinteractive#548

I'm cherry-picking because of merging because we are trying to avoid the deprecation notices for Fieldmanager_Context_Page and add_submenu_page().

@astratagem
Copy link
Copy Markdown
Author

@kingkool68 ready for review. Note that these changes will be deployed to production the next time composer.lock is updated on master, or when https://github.com/spiritedmedia/spiritedmedia/pull/2768 is merged.

Copy link
Copy Markdown

@kingkool68 kingkool68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sure!

@kingkool68 kingkool68 assigned astratagem and unassigned kingkool68 Jul 31, 2018
@astratagem astratagem merged commit ff63705 into spiritedmedia Jul 31, 2018
@astratagem astratagem deleted the montchr-upstream-pr-658-radio-renumber branch July 31, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants