feat(javascript): add replaceAllObjectsWithTransformation#5008
Merged
feat(javascript): add replaceAllObjectsWithTransformation#5008
replaceAllObjectsWithTransformation#5008Conversation
142a5c0 to
bc5ed6c
Compare
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
bc5ed6c to
405c5e4
Compare
Member
Author
ah actually that would mean breaking the signature, I need to check if there is some usage first |
0ee2dc0 to
4be66cf
Compare
Member
Author
breaking all of them at once in #5011 |
millotp
reviewed
Jun 17, 2025
templates/javascript/clients/algoliasearch/builds/definition.mustache
Outdated
Show resolved
Hide resolved
| * @param chunkedPush.indexName - The `indexName` to replace `objects` in. | ||
| * @param chunkedPush.objects - The array of `objects` to store in the given Algolia `indexName`. | ||
| * @param chunkedPush.action - The `batch` `action` to perform on the given array of `objects`, defaults to `addObject`. | ||
| * @param chunkedPush.waitForTasks - Whether or not we should wait until every `batch` tasks has been processed, this operation may slow the total execution time of this method but is more reliable. |
Contributor
There was a problem hiding this comment.
does waitForTasks make sense here ? should it be waitForPush ?
Member
Author
There was a problem hiding this comment.
I copied chunkedBatch so it's usable the same way but since it's internal I can rename it if you want
| const responses: Array<WatchResponse> = []; | ||
|
|
||
| const objectEntries = objects.entries(); | ||
| for (const [i, obj] of objectEntries) { |
Contributor
There was a problem hiding this comment.
what about https://stackoverflow.com/a/8495740 ? I feel like it's more efficient and more readable
Member
Author
There was a problem hiding this comment.
I've actually just copied chunkedBatch 🥶
Member
Author
There was a problem hiding this comment.
I don't think it's IE compatible as well? I can't remember what version we should support but I think it's 11?
Contributor
There was a problem hiding this comment.
slice is available everywhere
Member
Author
There was a problem hiding this comment.
i'll update both implems in a follow up pr!
| if (waitForTasks) { | ||
| for (const resp of responses) { | ||
| if (resp.eventID === undefined || !resp.eventID) { | ||
| throw new Error('received unexpected response from the push endpoint, eventID must not be undefined'); |
Contributor
There was a problem hiding this comment.
IMO this error checking should be in loop above, to early exit.
Also in that case there should be an error message in the response
Member
Author
There was a problem hiding this comment.
I actually had to put it here to satisfy the type checking (same for Go and other languages), I can duplicate it, but this one is required
templates/javascript/clients/algoliasearch/builds/definition.mustache
Outdated
Show resolved
Hide resolved
millotp
reviewed
Jun 18, 2025
templates/javascript/clients/algoliasearch/builds/definition.mustache
Outdated
Show resolved
Hide resolved
millotp
approved these changes
Jun 18, 2025
algolia-bot
added a commit
that referenced
this pull request
Jun 18, 2025
…generated) [skip ci] Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Jun 18, 2025
algolia/api-clients-automation#5008 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Jun 18, 2025
algolia/api-clients-automation#5008 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Jun 18, 2025
algolia/api-clients-automation#5008 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Jun 18, 2025
algolia/api-clients-automation#5008 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jun 18, 2025
algolia/api-clients-automation#5008 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Jun 18, 2025
algolia/api-clients-automation#5008 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Jun 18, 2025
algolia/api-clients-automation#5008 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Jun 18, 2025
algolia/api-clients-automation#5008 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Jun 18, 2025
algolia/api-clients-automation#5008 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Jun 18, 2025
algolia/api-clients-automation#5008 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Jun 18, 2025
algolia/api-clients-automation#5008 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3894
Changes included:
this adds the helper to replace all of the content of an index by leveraging the transformation pipeline, i've inlined the chunkedPush logic but actually could be reused in the saveObjects and partialUpdateObjects methods as well, lmk