fix(clients): allow chunked requests on WithTransformation methods#5011
Merged
fix(clients): allow chunked requests on WithTransformation methods#5011
Conversation
0ee2dc0 to
4be66cf
Compare
f04c413 to
9254f25
Compare
Collaborator
💥 Breaking changes detected !!Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging. ✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
aff8b9c to
a160398
Compare
Base automatically changed from
feat/javascript-replaceAllObjectsWithTransformation
to
main
June 18, 2025 14:07
4fcc10f to
916186a
Compare
millotp
approved these changes
Jun 18, 2025
Contributor
millotp
left a comment
There was a problem hiding this comment.
looks great, nothing to add !
algolia-bot
added a commit
that referenced
this pull request
Jun 18, 2025
…5011) (generated) [skip ci] Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Jun 18, 2025
…enerated) algolia/api-clients-automation#5011 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Jun 18, 2025
…enerated) algolia/api-clients-automation#5011 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jun 18, 2025
…enerated) algolia/api-clients-automation#5011 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Jun 18, 2025
…enerated) algolia/api-clients-automation#5011 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Jun 18, 2025
…enerated) algolia/api-clients-automation#5011 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Jun 18, 2025
…enerated) algolia/api-clients-automation#5011 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3897 https://algolia.atlassian.net/browse/DI-3896 https://algolia.atlassian.net/browse/DI-3893 https://algolia.atlassian.net/browse/DI-3895
Changes included:
this pr implements the chunkedPush method in every clients that has WithTransformation helpers, which allows the implementation of a subsequent helper: ReplaceAllObjectsWithTransformation
this updates the response type of the previously added helpers but they are unlikely to be used atm considering it just has been released and not even documented