Update dependencies (v2)#317
Update dependencies (v2)#317kibertoad wants to merge 1 commit intoairtap:masterfrom kibertoad:chore/deps-2021-09-05
Conversation
|
CI seems to be broken, btw. Would you be open to a PR, switching from Travis to GitHub Actions? |
|
Thanks so much for this! Limiting the amount of updates makes this easier to review and merge than #315. As for the changes:
Correct. Airtap does run multiple servers, but it's one per browser, so a browser only ever connects to one server.
👍 |
That would be most welcome. Thanks! |
|
I do have two remaining questions - same as #315 (comment):
|
|
@vweevers I see classes and default arguments, I take it that means "yes" on the first one? |
In that case we will (unfortunately) need to transpile the client bundle to ES5 (#276). E.g. by adding a babel transform to this browserify instance.
If not documented by engine-io (?) then we can run tests in Sauce Labs. Which would be good anyway. To do so, clone |
|
I see that |
|
Hey folks is this stalled? Does anyone need help getting this landed? |
|
Feel free to pick this up, the state is as written above (and in addition this PR needs a rebase). I'm not going to work on this in the foreseeable future, because it's only about removing a false positive alert. Which is not a priority for me especially if it results in breaking changes that necessitate adding a transpiler. Do you want to send a PR to tackle that? |
fixes #312
There are two major updates,
engine.ioandengine.io-client. The only significant changes are on server side, client was only updated to accommodate for it. Here is the list of potentially breaking changes:handlePreflightRequestremoved from CORS (was not used in the airtap);