Skip to content

Bump dependencies to latest versions#315

Closed
jzombie wants to merge 1 commit intoairtap:masterfrom
jzombie:feature/deps-update
Closed

Bump dependencies to latest versions#315
jzombie wants to merge 1 commit intoairtap:masterfrom
jzombie:feature/deps-update

Conversation

@jzombie
Copy link
Copy Markdown
Contributor

@jzombie jzombie commented May 28, 2021

No description provided.

@jzombie
Copy link
Copy Markdown
Contributor Author

jzombie commented May 28, 2021

Tests report that they have all passed, though there were some peculiarities in both the master branch and my own branch regarding timeouts which never closed the browser. Maybe I was doing something wrong.

There is one remaining high severity vulnerability in the trim package:

┌──────────────────────────────────────────────────────────────────────────────┐
│ Manual Review │
│ Some vulnerabilities require your attention to resolve │
│ │
│ Visit https://go.npm.me/audit-guide for additional guidance │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High │ Regular Expression Denial of Service in trim │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ trim │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=0.0.3 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ hallmark [dev] │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ hallmark > remark > remark-parse > trim │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://npmjs.com/advisories/1700
└───────────────┴──────────────────────────────────────────────────────────────┘

@jzombie

This comment has been minimized.

@jzombie

This comment has been minimized.

@jzombie
Copy link
Copy Markdown
Contributor Author

jzombie commented May 28, 2021

Also did a standard --fix to fix the usage of vars, as it had linting errors after bumping the deps.

@vweevers
Copy link
Copy Markdown
Member

though there were some peculiarities in both the master branch and my own branch regarding timeouts which never closed the browser

This is expected, the tests verify that when a timeout occurs, it is handled correctly. The test output can be confusing at times, when it mixes in browser test results that are expected to contain failures.

@jimmywarting
Copy link
Copy Markdown

Currently it seems like it is installing two versions of browserify, would be grate to get this updated to 17

Comment on lines +1 to +2
const load = require('load-script')
const engineClient = require('engine.io-client')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these, as well as the other changes in this file. We're using var to support old browsers.

If standard gives you trouble, you can use an eslint-disable <rule> comment.

"airtap-default": "^1.0.0",
"airtap-multi": "^1.0.0",
"browserify": "^16.5.2",
"browserify": "^17.0.0",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of this upgrade, airtap users will have to take an additional step to test on IE11. Can you please update this readme section? It should say:

To support IE < 11, older versions of the buffer and stream-browserify polyfills are required. Use the following configuration and run npm install buffer@4 stream-browserify@2:

# Use buffer@4 and stream-browserify@2 to support IE < 11
browserify:
 - require: 'buffer/'
   expose: 'buffer'
 - require: 'stream-browserify'
   expose: 'stream'

Comment on lines +34 to +35
"engine.io": "^5.1.1",
"engine.io-client": "5.1.1",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough information to merge this PR. Please check the following:

  1. Is latest engine.io-client using ES6+ features? Which is why we currently pin to 3.3.2.
  2. What breaking changes were made between engine.io-client v3 and v5?
  3. Do they support the same browsers (versions)?
  4. What breaking changes were made between engine.io v3 and v5?

@vweevers vweevers mentioned this pull request Sep 5, 2021
vweevers added a commit that referenced this pull request Nov 27, 2021
Closes vulnerability alerts. We're jumping several versions ahead
but by using the transpiled (ES5) flavor of `engine.io-client` it
should not affect browser support of `airtap`. IE9 is still
supported.

Closes #276, closes #317, closes #312, closes #315.
@vweevers vweevers closed this in 5e7560b Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants