Conversation
|
Tests report that they have all passed, though there were some peculiarities in both the master branch and my own branch regarding timeouts which never closed the browser. Maybe I was doing something wrong. There is one remaining high severity vulnerability in the trim package: ┌──────────────────────────────────────────────────────────────────────────────┐ |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Also did a standard --fix to fix the usage of vars, as it had linting errors after bumping the deps. |
This is expected, the tests verify that when a timeout occurs, it is handled correctly. The test output can be confusing at times, when it mixes in browser test results that are expected to contain failures. |
|
Currently it seems like it is installing two versions of browserify, would be grate to get this updated to 17 |
| const load = require('load-script') | ||
| const engineClient = require('engine.io-client') |
There was a problem hiding this comment.
Please revert these, as well as the other changes in this file. We're using var to support old browsers.
If standard gives you trouble, you can use an eslint-disable <rule> comment.
| "airtap-default": "^1.0.0", | ||
| "airtap-multi": "^1.0.0", | ||
| "browserify": "^16.5.2", | ||
| "browserify": "^17.0.0", |
There was a problem hiding this comment.
Because of this upgrade, airtap users will have to take an additional step to test on IE11. Can you please update this readme section? It should say:
To support IE < 11, older versions of the
bufferandstream-browserifypolyfills are required. Use the following configuration and runnpm install buffer@4 stream-browserify@2:# Use buffer@4 and stream-browserify@2 to support IE < 11 browserify: - require: 'buffer/' expose: 'buffer' - require: 'stream-browserify' expose: 'stream'
| "engine.io": "^5.1.1", | ||
| "engine.io-client": "5.1.1", |
There was a problem hiding this comment.
I don't have enough information to merge this PR. Please check the following:
- Is latest
engine.io-clientusing ES6+ features? Which is why we currently pin to 3.3.2. - What breaking changes were made between
engine.io-clientv3 and v5? - Do they support the same browsers (versions)?
- What breaking changes were made between
engine.iov3 and v5?
No description provided.