Build(deps): Bump isort from 4.3.21 to 5.2.2#123
Closed
dependabot-preview[bot] wants to merge 1 commit intomasterfrom
Closed
Build(deps): Bump isort from 4.3.21 to 5.2.2#123dependabot-preview[bot] wants to merge 1 commit intomasterfrom
dependabot-preview[bot] wants to merge 1 commit intomasterfrom
Conversation
Bumps [isort](https://github.com/timothycrosley/isort) from 4.3.21 to 5.2.2. - [Release notes](https://github.com/timothycrosley/isort/releases) - [Changelog](https://github.com/timothycrosley/isort/blob/develop/CHANGELOG.md) - [Commits](PyCQA/isort@4.3.21...5.2.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 50 50
Branches 5 5
=========================================
Hits 50 50 Continue to review full report at Codecov.
|
Contributor
Author
|
Dependabot tried to automerge this PR, but received the following error from GitHub: |
Contributor
Author
|
Dependabot tried to automerge this PR, but received the following error from GitHub: |
Contributor
Author
|
Superseded by #125. |
bdraco
added a commit
that referenced
this pull request
Jun 9, 2025
This PR modifies the build backend to dynamically enable Cython line tracing only when explicitly requested via the `with-cython-tracing=true` config setting. Previously, having `linetrace = "True"` in pyproject.toml was causing build issues for users (#658) and makes our production wheels almost half as fast. Now, line tracing is opt-in: - Regular builds: `pip install .` (no line tracing) - Tracing builds: `pip install . --config-setting=with-cython-tracing=true` (enables line tracing) When tracing is requested, the build backend automatically adds the `linetrace=True` and `profile=True` Cython directives and sets the appropriate C compiler flags. <!-- Outline any notable behaviour for the end users. --> - Regular users will no longer encounter build issues related to line tracing being enabled by default - Developers who need line tracing must now explicitly enable it using `--config-setting=with-cython-tracing=true` - The `YARL_CYTHON_TRACING` environment variable can also be used as an alternative to the config setting <!-- Are there any issues opened that will be resolved by merging this change? --> <!-- Remember to prefix with 'Fixes' if it should close the issue (e.g. 'Fixes #123'). --> - [x] I think the code is well written - [ ] Unit tests for the changes exist - [ ] Documentation reflects the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps isort from 4.3.21 to 5.2.2.
Release notes
Sourced from isort's releases.
Changelog
Sourced from isort's changelog.
Commits
253b947Bump version number39adceeFixed #1356: return status when arguments are passed in without files or a co...b8c8c00Add precommit section to upgrade guide212e160Update isort config107bf48Add custom isort documentation theme444c4eePrepare 5.2.1 released16a72fAdd recursive symlink protection368556eDefault filter-files to true in precommit hook92b84bdImprove handling of relative path detection1bf93c7Fix small formatting issueDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.If all status checks pass Dependabot will automatically merge this pull request.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.ymlfile in this repo: