api: add Topology aware support#235
Merged
Merged
Conversation
…y management Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…d constraints Signed-off-by: Ron Kahn <rkahn@nvidia.com>
7eb1c65 to
d667527
Compare
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…d constraints Signed-off-by: Ron Kahn <rkahn@nvidia.com>
sanjaychatterjee
requested changes
Oct 28, 2025
sanjaychatterjee
left a comment
Collaborator
There was a problem hiding this comment.
I think we are missing the Grove's pre-defined topology level constants?
shayasoolin
reviewed
Oct 28, 2025
shayasoolin
reviewed
Oct 28, 2025
…d constraints Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…and constraints Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…d validation Signed-off-by: Ron Kahn <rkahn@nvidia.com>
- Remove redundant comment for TopologyDomainList.Items field - Change 'highest' to 'broadest' for consistency with scope terminology Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…mentation files Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
- Rename TopologyDomain -> ClusterTopology with shortName ct - Rename TopologyLevelName type -> TopologyDomain type - Rename PackLevel field -> PackDomain - Rename TopologyLevel.Name -> Domain, TopologyKey -> Key - Update all generated code and CRDs Signed-off-by: Ron Kahn <rkahn@nvidia.com>
… levels constants Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…Topology Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…opologyDomain Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Update operator-api.md with simpler markdown table syntax Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
sanjaychatterjee
approved these changes
Nov 2, 2025
sanjaychatterjee
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api
What this PR does / why we need it
This PR introduces topology-aware scheduling APIs for network locality optimization in multi-node AI inference workloads.
Which issue(s) this PR fixes:
Fixes #245
Key additions
ClusterTopology CRD: Cluster-scoped singleton (user-chosen name) defining topology hierarchy by mapping level names (region/zone/datacenter/block/rack/host/numa) to node labels. Immutable with deletion protection via finalizer.
TopologyConstraint fields:
packDomainadded to PodCliqueSet, PodCliqueScalingGroup, and PodClique for per-replica placement within one topology domainPodGang API: Three-level constraints (gang/scaling-group/clique) with required (user-specified) and preferred (auto-generated) semantics, annotation-based topology reference
Removed deprecated fields
PodCliqueSetSpec.replicaSpreadConstraintsPodCliqueSetTemplateSpec.schedulingPolicyConfigandNetworkPackGroupConfigPodGangSpec.spreadConstraintsandnetworkPackGroupConfigsNote: API-only PR. Controller logic, validation webhooks, and translation implementation in follow-up PRs.
Does this PR introduce an API change?
action required: Removed deprecated scheduling fields. Added ClusterTopology CRD and topology constraints. Existing workloads using
replicaSpreadConstraintsorschedulingPolicyConfigmust migrate. Admins must create ClusterTopology and aligned Kueue Topology before enabling topology features.Additional documentation
Design document: #224