Grove proposal/topology#224
Merged
Merged
Conversation
romanbaron
reviewed
Oct 21, 2025
romanbaron
reviewed
Oct 21, 2025
romanbaron
reviewed
Oct 21, 2025
romanbaron
reviewed
Oct 21, 2025
sanjaychatterjee
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR. Added some comments to simplify the implementation.
shayasoolin
reviewed
Oct 22, 2025
omer-dayan
reviewed
Oct 22, 2025
omer-dayan
reviewed
Oct 22, 2025
unmarshall
requested changes
Oct 22, 2025
unmarshall
left a comment
Collaborator
There was a problem hiding this comment.
I have only partly done the review. Posting comments in batches.
renormalize
reviewed
Oct 22, 2025
renormalize
left a comment
Contributor
There was a problem hiding this comment.
thanks for the proposal!
1/n as I have yet to go through most of the document.
shayasoolin
reviewed
Oct 26, 2025
kangclzjc
reviewed
Oct 27, 2025
Contributor
|
And for GB200, not sure how do integrate nvlink domin with this topology? And if I use nvidia-gpu-driver-plugin for imex, would it conflict with this topology? |
sanjaychatterjee
requested changes
Oct 27, 2025
gflarity
previously approved these changes
Oct 28, 2025
gflarity
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Ronkahn21! IMO we should simplify things and just go with the Kueue CR since it's required regardless. Having both just seems like more work for the Admin for very little benefit. I don't want to waste any time with a debate though if I can't convince you. 🚢 it :)
gflarity
reviewed
Oct 29, 2025
sanjaychatterjee
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR update. Mostly looks good to me. Once you fix the OperatorConfiguration CRD issue, I can approve.
sanjaychatterjee
previously approved these changes
Oct 29, 2025
sanjaychatterjee
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Thanks!
4068734 to
b683fb1
Compare
unmarshall
previously requested changes
Oct 30, 2025
Ronkahn21
commented
Oct 30, 2025
sanjaychatterjee
approved these changes
Nov 2, 2025
…ator Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
typo fix Co-authored-by: Roman Baron <91824211+romanbaron@users.noreply.github.com> Signed-off-by: Ron Kahn <122778260+Ronkahn21@users.noreply.github.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Co-authored-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com> Signed-off-by: Ron Kahn <122778260+Ronkahn21@users.noreply.github.com>
…pologyDomain Signed-off-by: Ron Kahn <rkahn@nvidia.com>
… for TopologyDomain Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…and constraints Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…and clarify level definitions Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…nfig and annotations Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com> Signed-off-by: Sanjay Chatterjee <sanjay.chatterjee@gmail.com>
…umentation Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…usterTopology and clarify resource definitions Signed-off-by: Ron Kahn <rkahn@nvidia.com>
… protection, and enable/disable behavior Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…ming and clarify setup instructions Signed-off-by: Ron Kahn <rkahn@nvidia.com>
…d clarify resource management Signed-off-by: Ron Kahn <rkahn@nvidia.com>
d6f7b9d to
7e7878f
Compare
All prior comments have been addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
/kind feature
What this PR does / why we need it:
This PR adds a comprehensive design document for topology-aware scheduling in the Grove operator. The design introduces a flexible topology system that enables optimal placement of multinode inference
workloads based on cluster network topology.
Key components:
--topology-domain-nameargumentThe design addresses critical requirements for multinode inference workloads including network locality, coordinated placement, and latency optimization.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a API change?
suggest change