feat: promote FleetAutoscaleRequestMetaData to beta by sugar-cat7 · Pull Request #4365 · agones-dev/agones

sugar-cat7 · 2025-12-01T13:57:26Z

What type of PR is this?
/kind feature

What this PR does / Why we need it:
promote FleetAutoscaleRequestMetaData to beta

Which issue(s) this PR fixes:

Special notes for your reviewer:

markmandel

Thanks for the submission 🥳 , but I also noticed that we don't have any documentation on this feature in https://agones.dev/site/docs/reference/fleetautoscaler/#webhook-endpoint-specification

Any chance you want to also add them as part of this PR?

markmandel · 2025-12-02T04:59:08Z

site/content/en/docs/Guides/feature-stages.md

 | [Player Tracking]({{< ref "/docs/Guides/player-tracking.md" >}})                                                           | `PlayerTracking`                   | Disabled | `Alpha`  | 1.6.0  |
 | [Scheduled Fleet Autoscaling](https://github.com/googleforgames/agones/issues/3008)                                        | `ScheduledAutoscaler`              | Enabled  | `Beta`   | 1.51.0 |
-| [Extend Webhook autoscaler to send fleet metadata with the request](https://github.com/googleforgames/agones/issues/3951)  | `FleetAutoscaleRequestMetaData`    | Disabled | `Alpha`  | 1.48.0 |
+| [Extend Webhook autoscaler to send fleet metadata with the request](https://github.com/googleforgames/agones/issues/3951)  | `FleetAutoscaleRequestMetaData`    | Enabled  | `Beta`   | 1.48.0 |


Same things as #4364 - this shouldn't be changed, since this is the current docs that are displayed, and the feature will only move in the next version.

fix
d707615

markmandel · 2025-12-02T17:44:45Z

/gcbrun (not that I think there will be an issue)

agones-bot · 2025-12-02T18:23:57Z

Build Failed 😭

Build Id: 16a61980-7824-430a-bf59-834c4fe8eef8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

sugar-cat7 · 2025-12-03T16:31:23Z

Thanks for the submission 🥳 , but I also noticed that we don't have any documentation on this feature in https://agones.dev/site/docs/reference/fleetautoscaler/#webhook-endpoint-specification

Any chance you want to also add them as part of this PR?

I added a brief description of FleetAutoscaleRequestMetaData.
Should I also add a similar description to the Fleet manifest example and the Wasm Function docs?

markmandel · 2025-12-05T04:18:35Z

site/content/en/docs/Reference/fleetautoscaler.md

 The `FleetAutoscaleResponse`'s `Replica` field is used to set the target `Fleet` count with each sync interval, thereby
 providing the autoscaling functionality.

+{{< beta title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}}


Forgot to mention, will need to be feature short coded like so:

https://agones.dev/site/docs/contribute/documentation-editing-contribution/#within-a-page

1.54.0 just released, so the shortcode and version numbers in this PR will also need to be updated.

Thanks!

I’ve added the feature shortcode.
e9f4ba8

markmandel

Not sure if the ticket captured everything in:

https://github.com/googleforgames/agones/blob/e2d352233317c7f7a3acf091d6b25aed1757da6c/pkg/util/runtime/features.go#L113-L121

So you also need to do:
https://github.com/googleforgames/agones/blob/e2d352233317c7f7a3acf091d6b25aed1757da6c/cloudbuild.yaml#L309-L311

But otherwise, this is looking good! Thanks!

markmandel · 2025-12-06T23:02:55Z

site/content/en/docs/Reference/fleetautoscaler.md

+{{% feature publishVersion="1.54.0" %}}
+{{< beta title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}}
+
+When the `FleetAutoscaleRequestMetaData` feature gate is enabled by default, the Fleet's `labels` and 
+`annotations` are included in the `FleetAutoscaleRequest`, allowing webhooks to make scaling decisions based on 
+Fleet-specific metadata.
+{{% /feature %}}


This would bring things up to date for what is current, and also move it to beta with the next release 👍🏻

Suggested change

{{% feature publishVersion="1.54.0" %}}

{{< beta title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}}

When the `FleetAutoscaleRequestMetaData` feature gate is enabled by default, the Fleet's `labels` and

`annotations` are included in the `FleetAutoscaleRequest`, allowing webhooks to make scaling decisions based on

Fleet-specific metadata.

{{% /feature %}}

{{% feature expireyVersion="1.54.0" %}}

{{< alpha title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}}

{{% /feature %}}

{{% feature publishVersion="1.54.0" %}}

{{< beta title="Fleet Metadata in Webhook Requests" gate="FleetAutoscaleRequestMetaData" >}}

{{% /feature %}}

When the `FleetAutoscaleRequestMetaData` feature gate is enabled, the Fleet's `labels` and

`annotations` are included in the `FleetAutoscaleRequest`, allowing webhooks to make scaling decisions based on

Fleet-specific metadata.

Thank you! I've made the changes.
dd07e26
2a9e4ef

markmandel · 2025-12-06T23:07:45Z

/gcbrun

agones-bot · 2025-12-07T00:03:48Z

Build Succeeded 🥳

Build Id: 91dce7b4-711a-487f-9e5b-9c18ef0c586a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.54.0-dev-e9f4ba8
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.54.0-dev-e9f4ba8
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.54.0-dev-e9f4ba8-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.54.0-dev-e9f4ba8
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.54.0-dev-e9f4ba8
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.54.0-dev-e9f4ba8
Linux C++ SDK (build): agonessdk-1.54.0-dev-e9f4ba8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.54.0-dev-e9f4ba8.zip

A preview of the website (the last 30 builds are retained):

https://e9f4ba8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4365/head:pr_4365 && git checkout pr_4365
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-e9f4ba8

Co-authored-by: Mark Mandel <mark@compoundtheory.com>

markmandel

Nice!

markmandel · 2025-12-12T18:17:12Z

/gcbrun

agones-bot · 2025-12-12T18:27:12Z

Build Failed 😭

Build Id: d20d8330-3bbf-4e80-9885-8b31ed1be223

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

site/content/en/docs/Reference/fleetautoscaler.md

Co-authored-by: Mark Mandel <mark@compoundtheory.com>

markmandel · 2025-12-13T01:49:29Z

/gcbrun

agones-bot · 2025-12-13T02:43:56Z

Build Failed 😭

Build Id: 41733f92-0bc7-4f6c-94fc-962647011879

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2025-12-13T02:56:46Z

/gcbrun

Haven't had a flake in a while. Will look properly later.

agones-bot · 2025-12-13T03:59:07Z

Build Succeeded 🥳

Build Id: e12c1ff6-3a02-495a-9966-b2e67f1768b5

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.55.0-dev-0485ec3
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.55.0-dev-0485ec3
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.55.0-dev-0485ec3-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.55.0-dev-0485ec3
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.55.0-dev-0485ec3
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.55.0-dev-0485ec3
Linux C++ SDK (build): agonessdk-1.55.0-dev-0485ec3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.55.0-dev-0485ec3.zip

A preview of the website (the last 30 builds are retained):

https://0485ec3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4365/head:pr_4365 && git checkout pr_4365
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-0485ec3

* Promote FleetAutoscaleRequestMetaData to Beta * reflect comments * add documentation * update feature short coded * fix cloudbuild * fix docs Co-authored-by: Mark Mandel <mark@compoundtheory.com> * typo expiryVersion Co-authored-by: Mark Mandel <mark@compoundtheory.com> --------- Co-authored-by: Mark Mandel <mark@compoundtheory.com>

Promote FleetAutoscaleRequestMetaData to Beta

4d3dadb

github-actions bot added kind/feature New features for Agones size/S labels Dec 1, 2025

markmandel reviewed Dec 2, 2025

View reviewed changes

sugar-cat7 added 3 commits December 4, 2025 00:55

Merge branch 'main' into feat/promote-fleetautoscaler-request-metadata

cb558cd

reflect comments

d707615

add documentation

0fd36ef

sugar-cat7 requested a review from markmandel December 3, 2025 16:32

markmandel reviewed Dec 5, 2025

View reviewed changes

update feature short coded

e9f4ba8

sugar-cat7 requested a review from markmandel December 6, 2025 12:33

markmandel reviewed Dec 6, 2025

View reviewed changes

sugar-cat7 and others added 2 commits December 8, 2025 02:36

fix cloudbuild

2a9e4ef

fix docs

dd07e26

Co-authored-by: Mark Mandel <mark@compoundtheory.com>

sugar-cat7 requested a review from markmandel December 7, 2025 17:41

markmandel approved these changes Dec 12, 2025

View reviewed changes

Merge branch 'main' into feat/promote-fleetautoscaler-request-metadata

9a2d2cb

markmandel enabled auto-merge (squash) December 12, 2025 18:17

markmandel reviewed Dec 12, 2025

View reviewed changes

site/content/en/docs/Reference/fleetautoscaler.md Outdated Show resolved Hide resolved

typo expiryVersion

0485ec3

Co-authored-by: Mark Mandel <mark@compoundtheory.com>

auto-merge was automatically disabled December 13, 2025 01:18
Head branch was pushed to by a user without write access

markmandel merged commit 7459f0f into agones-dev:main Dec 13, 2025
4 checks passed

Conversation

sugar-cat7 commented Dec 1, 2025

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

markmandel Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

sugar-cat7 Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markmandel commented Dec 2, 2025

Uh oh!

agones-bot commented Dec 2, 2025

Uh oh!

sugar-cat7 commented Dec 3, 2025

Uh oh!

markmandel Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

sugar-cat7 Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

markmandel Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

sugar-cat7 Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

markmandel commented Dec 6, 2025

Uh oh!

agones-bot commented Dec 7, 2025

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

markmandel commented Dec 12, 2025

Uh oh!

agones-bot commented Dec 12, 2025

Uh oh!

Uh oh!

markmandel commented Dec 13, 2025

Uh oh!

agones-bot commented Dec 13, 2025

Uh oh!

markmandel commented Dec 13, 2025

Uh oh!

agones-bot commented Dec 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sugar-cat7 Dec 3, 2025 •

edited

Loading