Feat: Move SidecarContainers feature gate to Beta#4364
Feat: Move SidecarContainers feature gate to Beta#4364lacroixthomas merged 2 commits intoagones-dev:mainfrom
Conversation
|
/gcbrun |
lacroixthomas
left a comment
There was a problem hiding this comment.
Thanks for the contribution !
Got a minor change from the feature-stages.md, to match the next release version where it will be available in beta from (to 1.54.0)
|
done |
|
Build Succeeded 🥳 Build Id: 0254bc2d-e049-4aa8-ab8e-8e329cbb6a89 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
| | [Multiple dynamic port ranges](https://github.com/googleforgames/agones/issues/1911) | `PortRanges` | Enabled | `Beta` | 1.49.0 | | ||
| | [Rolling Update Fixes](https://github.com/googleforgames/agones/issues/3688) | `RollingUpdateFix` | Enabled | `Beta` | 1.50.0 | | ||
| | [Scheduled Fleet Autoscaling](https://github.com/googleforgames/agones/issues/3008) | `ScheduledAutoscaler` | Enabled | `Beta` | 1.51.0 | | ||
| | [Sidecar Containers](https://github.com/googleforgames/agones/issues/3642) | `SidecarContainers` | Enabled | `Beta` | 1.49.0 | |
There was a problem hiding this comment.
Ah! So close! I wonder if we can squeeze this in before the release tomorrow. If not, no big deal - we'll just need to increment the version numbers in the PR.
Unfortunately this should have not been edited (so leave SidecarContainers as alpha), since docs are published immediately and SidecarContainers are still in Alpha on the current version.
There was a problem hiding this comment.
will update it asap no worries
|
Oh, also noticed the issues with the CLA. If you look here: https://github.com/googleforgames/agones/pull/4364/checks?check_run_id=56852071285 You'll notice you have two separate commit emails for this PR, so either you need to rebase against the one account that has signed the CLA, or need to sign it again with the other email. |
|
the other author is @lacroixthomas , his CLA should be already signed, correct?? |
|
Hi @AryanBagade I already signed the CLA a long time ago, but it seems that when you applied the changes from my comment, it used one of my email that seems not to have the CLA signed 🤔 First time I see that Do you mind to do a rebase (to squash the commit with my name) with your account that have signed the CLA ? This should get rid of "my" commit and pass the CLA test Sorry about that, I'll have a look to understand why it happened |
oooh! That's what happened! Oopsie! Agreed -- @AryanBagade if you pull it down locally and squash the commits and And don't stress over timing -- we release every 6 weeks, so no rush. |
|
👋🏻 just checking in! Lemme know if you need a hand with the squashing and/or fixing the conflicts. |
|
@markmandel apologies for the delay, will be doing it soon!!!! |
|
Now worries, just making sure I'm offering appropriate support 😄 |
|
👋🏻 just checking in again. Happy to take this over if you no longer have time to do it. |
dfae69b to
259d9dc
Compare
|
Hope you don't mind - I took the liberty of updating this PR so we can get it into the next release. |
|
/gcbrun |
|
@lacroixthomas when you get a chance, can you have another look at this, assuming it passes, it should be good to go. |
|
Build Succeeded 🥳 Build Id: 7601dddc-9de4-41d0-8425-c4aad2b66e85 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Promotes the SidecarContainers feature gate from Alpha to Beta, making it enabled by default. This feature has been stable since v1.49.0 with no error reports.
728a7fb to
fcbc85f
Compare
|
/gcbrun This should be good now. |
|
Build Succeeded 🥳 Build Id: e84e4861-67be-4a1d-8687-8031a85433af The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
LGTM ! |
* Move SidecarContainers feature gate to Beta Promotes the SidecarContainers feature gate from Alpha to Beta, making it enabled by default. This feature has been stable since v1.49.0 with no error reports. * Review updates. --------- Co-authored-by: Mark Mandel <mark@compoundtheory.com>
Promotes the SidecarContainers feature gate from Alpha to Beta, making it enabled by default. This feature has been stable since v1.49.0 with no error reports
What type of PR is this?
/kind feature
What this PR does / Why we need it:
The SidecarContainers feature refactors how the SDK server runs by utilizing Kubernetes native sidecar container support, decoupling the SDK lifecycle from the GameServer container lifecycle. This feature has been in Alpha since v1.49.0 with no reported issues, indicating it is ready for broader adoption.
Which issue(s) this PR fixes:
Closes #4361
Special notes for your reviewer:
SidecarContainersbeing disabled by default