Update Add and Remove List Value in SDK Server by Sivasankaran25 · Pull Request #4279 · agones-dev/agones

Sivasankaran25 · 2025-09-17T06:19:56Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #4275

Special notes for your reviewer:

agones-bot · 2025-09-17T06:29:22Z

Build Failed 😭

Build Id: c340657c-d6c5-4306-a3de-5ee09a0f45f1

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2025-09-17T06:32:00Z

/gcbrun

agones-bot · 2025-09-17T06:41:19Z

Build Failed 😭

Build Id: fcc10e19-65b1-4747-b427-255971ef3391

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2025-09-17T07:45:16Z

/gcbrun

agones-bot · 2025-09-17T07:57:35Z

Build Failed 😭

Build Id: 6214c52a-00b3-4f12-80b7-e7e456cd8338

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2025-09-17T12:47:49Z

/gcbrun

agones-bot · 2025-09-17T12:57:10Z

Build Failed 😭

Build Id: 8b56e249-dccc-485b-80db-8d7f07b16bbe

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-09-17T18:05:13Z

Build Succeeded 🥳

Build Id: 51d1511e-f5d2-4ff8-a3ad-d60e3d8cd798

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-a4d82a5
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-a4d82a5
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-a4d82a5-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-a4d82a5
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-a4d82a5
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-a4d82a5
Linux C++ SDK (build): agonessdk-1.53.0-dev-a4d82a5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-a4d82a5.zip

A preview of the website (the last 30 builds are retained):

https://a4d82a5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4279/head:pr_4279 && git checkout pr_4279
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-a4d82a5

lacroixthomas · 2025-09-17T23:32:49Z

Maybe we could add some unit tests to ensure there will be no regression in the future ? It's strange that no unit tests fails now that we returns the proper values (maybe we were not checking returned values at all)

Sivasankaran25 · 2025-09-18T05:19:06Z

Maybe we could add some unit tests to ensure there will be no regression in the future ? It's strange that no unit tests fails now that we returns the proper values (maybe we were not checking returned values at all)

I have tested the test cases, and they are all passing. I also verified the behavior with the SDK, and it is working as expected.

agones-bot · 2025-09-18T05:34:15Z

Build Succeeded 🥳

Build Id: 4d3255bd-acb6-4b65-b6dc-d0670723a8c1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-a02e3df
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-a02e3df
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-a02e3df-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-a02e3df
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-a02e3df
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-a02e3df
Linux C++ SDK (build): agonessdk-1.53.0-dev-a02e3df-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-a02e3df.zip

A preview of the website (the last 30 builds are retained):

https://a02e3df-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4279/head:pr_4279 && git checkout pr_4279
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-a02e3df

agones-bot · 2025-09-22T04:45:02Z

Build Failed 😭

Build Id: 950d3964-ec8d-426b-9dee-35062e2728b1

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2025-09-22T04:46:49Z

/gcbrun

agones-bot · 2025-09-22T05:39:47Z

Build Succeeded 🥳

Build Id: 5e208ab9-9790-46d7-9f26-fd6846633adb

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-318ae60
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-318ae60
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-318ae60-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-318ae60
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-318ae60
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-318ae60
Linux C++ SDK (build): agonessdk-1.53.0-dev-318ae60-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-318ae60.zip

A preview of the website (the last 30 builds are retained):

https://318ae60-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4279/head:pr_4279 && git checkout pr_4279
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-318ae60

agones-bot · 2025-10-02T05:59:32Z

Build Succeeded 🥳

Build Id: 122449e5-7cbc-4d8e-b0fd-aba027f435ca

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-3efb943
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-3efb943
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-3efb943-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-3efb943
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-3efb943
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-3efb943
Linux C++ SDK (build): agonessdk-1.53.0-dev-3efb943-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-3efb943.zip

A preview of the website (the last 30 builds are retained):

https://3efb943-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4279/head:pr_4279 && git checkout pr_4279
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-3efb943

igooch

Not explicitly mentioned in the issue for this PR is that the RemoveListValues and AddListValues are expected to be atomic. In general, I'm not sure what the benefit is of only holding the update diffs gsCounterUpdates map[string]counterUpdateRequest and gsListUpdates map[string]listUpdateRequest instead of keeping a full copy of the Counter or List that will be updated, and then on batch applying the copy of the Counter or List. If this List is large there might be some memory benefit.

igooch · 2025-09-22T16:09:30Z

pkg/sdkserver/sdkserver.go

 			return nil, errors.Errorf("already exists. Value: %s already in List: %s", in.Value, in.Name)
 		}
 	}
+	if in.Value == "" {


Why this check? We don't have a requirement specifying that the string cannot be empty, only that a string must be unique.

igooch · 2025-10-08T03:57:44Z

pkg/sdkserver/sdkserver.go

-	for _, val := range list.Values {
-		if in.Value != val {
-			continue
+	// Remove the first matching value directly from the in-memory list


We don't allow duplicate values, so there should only be one matching value in the list.

igooch · 2025-10-08T04:34:14Z

pkg/sdkserver/sdkserver.go

 	list.Values = append(list.Values, in.Value)
 	batchList := s.gsListUpdates[in.Name]
 	batchList.valuesToAppend = list.Values


Looks like this is a pre-existing bug. The valuesToAppend shouldn't contain the entire list, only the valuesToAppend and the new value.

Suggested change

list.Values = append(list.Values, in.Value)

batchList := s.gsListUpdates[in.Name]

batchList.valuesToAppend = list.Values

batchList := s.gsListUpdates[in.Name]

batchList.valuesToAppend = append(batchList.valuesToAppend, in.Value)

You might need to do the append(batchList.valuesToAppend, in.Value) in a separate variable first.

pkg/sdkserver/sdkserver.go

agones-bot · 2025-10-08T05:32:18Z

Build Succeeded 🥳

Build Id: c5b17758-356c-4d25-95a7-428f12a3be24

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-6ff29f2
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-6ff29f2
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-6ff29f2-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-6ff29f2
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-6ff29f2
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-6ff29f2
Linux C++ SDK (build): agonessdk-1.53.0-dev-6ff29f2-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-6ff29f2.zip

A preview of the website (the last 30 builds are retained):

https://6ff29f2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4279/head:pr_4279 && git checkout pr_4279
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-6ff29f2

agones-bot · 2025-10-09T07:29:12Z

Build Failed 😭

Build Id: b798db6a-1710-460f-909d-a34a206dd5dd

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2025-10-09T07:32:13Z

/gcbrun

agones-bot · 2025-10-09T08:20:00Z

Build Failed 😭

Build Id: 3f3aa7b5-a4f8-4053-9a7f-42ea085bd7ff

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-09T09:51:22Z

Build Failed 😭

Build Id: 028670b0-5f44-4707-bc96-ea216530b19c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-09T11:52:54Z

Build Failed 😭

Build Id: 67640fd5-63c7-4a66-84b6-45e0c2ae4542

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-09T13:48:33Z

Build Failed 😭

Build Id: a7f53c10-eee1-4f09-ae85-21d7a264246c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-10T05:40:48Z

Build Failed 😭

Build Id: cabfc04c-82fe-4dcc-a153-70a3650e35d4

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-10T07:42:11Z

Build Failed 😭

Build Id: 3f79f1c8-7f8e-4e0c-b1d4-dc46d499f743

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-10T08:31:51Z

Build Failed 😭

Build Id: c3bae748-ed99-4bcc-9985-ab891f0e800f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2025-10-13T04:05:42Z

/gcbrun

agones-bot · 2025-10-13T04:54:40Z

Build Failed 😭

Build Id: 80423dbf-9b12-49ae-8fb0-514253d73c6f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-14T15:54:30Z

Build Failed 😭

Build Id: f40f4268-7cc6-4b4f-9303-0893bb53765b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-14T19:03:51Z

Build Succeeded 🥳

Build Id: 23b51bdd-c463-4c4d-b7fd-f68608d843ce

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-20b1fb8
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-20b1fb8
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-20b1fb8-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-20b1fb8
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-20b1fb8
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-20b1fb8
Linux C++ SDK (build): agonessdk-1.53.0-dev-20b1fb8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-20b1fb8.zip

A preview of the website (the last 30 builds are retained):

https://20b1fb8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4279/head:pr_4279 && git checkout pr_4279
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-20b1fb8

agones-bot · 2025-10-15T05:26:42Z

Build Succeeded 🥳

Build Id: 26dd346a-b6a7-4920-9780-aa630239e574

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-3c41560
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-3c41560
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-3c41560-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-3c41560
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-3c41560
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-3c41560
Linux C++ SDK (build): agonessdk-1.53.0-dev-3c41560-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-3c41560.zip

A preview of the website (the last 30 builds are retained):

https://3c41560-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4279/head:pr_4279 && git checkout pr_4279
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-3c41560

igooch

One last item, then looks good!

pkg/sdkserver/sdkserver.go

agones-bot · 2025-10-16T06:48:24Z

Build Failed 😭

Build Id: 353b1c23-773f-4978-9392-f684d55c3228

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2025-10-16T06:52:06Z

/gcbrun

agones-bot · 2025-10-16T07:52:07Z

Build Succeeded 🥳

Build Id: 87eee7a0-7baa-4a6a-ade4-62c535b69138

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-9d9f29c
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-9d9f29c
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-9d9f29c-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-9d9f29c
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-9d9f29c
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-9d9f29c
Linux C++ SDK (build): agonessdk-1.53.0-dev-9d9f29c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-9d9f29c.zip

A preview of the website (the last 30 builds are retained):

https://9d9f29c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4279/head:pr_4279 && git checkout pr_4279
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-9d9f29c

igooch

Thanks for the work!

pkg/sdkserver/sdkserver.go

* Update Add and Remove List Value in SDK Server * fix add and remove list value testcases * Update comments changes * remove string empty condition * remove unwanted lines * Remove health state in Supertukart test * Update Inital Delay Seconds * Restore previous values in Initial Delay Seconds * Update inital Delay Seconds * Update inital Delay Seconds * Update inital Delay Seconds * update gameserver e2e file

Sivasankaran25 requested review from gongmax, igooch and markmandel September 17, 2025 06:19

Sivasankaran25 self-assigned this Sep 17, 2025

github-actions bot added kind/bug These are bugs. size/S labels Sep 17, 2025

igooch reviewed Oct 8, 2025

View reviewed changes

Sivasankaran25 added 11 commits October 14, 2025 15:08

Update Add and Remove List Value in SDK Server

5cc0130

fix add and remove list value testcases

ee2c810

Update comments changes

26bfbd3

remove string empty condition

b808add

remove unwanted lines

dc41029

Remove health state in Supertukart test

52f5b53

Update Inital Delay Seconds

3ab9a8e

Restore previous values in Initial Delay Seconds

d27c6a7

Update inital Delay Seconds

9a99ab8

Update inital Delay Seconds

461e4e6

Update inital Delay Seconds

5a67cef

Sivasankaran25 force-pushed the update_add_remove_value branch from d032f05 to 5a67cef Compare October 14, 2025 15:12

update gameserver e2e file

20b1fb8

Merge branch 'main' into update_add_remove_value

3c41560

igooch reviewed Oct 16, 2025

View reviewed changes

pkg/sdkserver/sdkserver.go Show resolved Hide resolved

Merge branch 'main' into update_add_remove_value

9d9f29c

igooch approved these changes Oct 17, 2025

View reviewed changes

pkg/sdkserver/sdkserver.go Show resolved Hide resolved

igooch merged commit 1eca765 into agones-dev:main Oct 17, 2025
4 checks passed

Conversation

Sivasankaran25 commented Sep 17, 2025

Uh oh!

agones-bot commented Sep 17, 2025

Uh oh!

Sivasankaran25 commented Sep 17, 2025

Uh oh!

agones-bot commented Sep 17, 2025

Uh oh!

Sivasankaran25 commented Sep 17, 2025

Uh oh!

agones-bot commented Sep 17, 2025

Uh oh!

Sivasankaran25 commented Sep 17, 2025

Uh oh!

agones-bot commented Sep 17, 2025

Uh oh!

agones-bot commented Sep 17, 2025

Uh oh!

lacroixthomas commented Sep 17, 2025

Uh oh!

Sivasankaran25 commented Sep 18, 2025

Uh oh!

agones-bot commented Sep 18, 2025

Uh oh!

agones-bot commented Sep 22, 2025

Uh oh!

Sivasankaran25 commented Sep 22, 2025

Uh oh!

agones-bot commented Sep 22, 2025

Uh oh!

agones-bot commented Oct 2, 2025

Uh oh!

igooch left a comment

Choose a reason for hiding this comment

Uh oh!

igooch Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

igooch Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

igooch Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

agones-bot commented Oct 8, 2025

Uh oh!

agones-bot commented Oct 9, 2025

Uh oh!

Sivasankaran25 commented Oct 9, 2025

Uh oh!

agones-bot commented Oct 9, 2025

Uh oh!

agones-bot commented Oct 9, 2025

Uh oh!

agones-bot commented Oct 9, 2025

Uh oh!

agones-bot commented Oct 9, 2025

Uh oh!

agones-bot commented Oct 10, 2025

Uh oh!

agones-bot commented Oct 10, 2025

Uh oh!

agones-bot commented Oct 10, 2025

Uh oh!

Sivasankaran25 commented Oct 13, 2025

Uh oh!

agones-bot commented Oct 13, 2025

Uh oh!

agones-bot commented Oct 14, 2025

Uh oh!

agones-bot commented Oct 14, 2025

Uh oh!

agones-bot commented Oct 15, 2025

Uh oh!

igooch left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

igooch left a comment •

edited

Loading