-
Notifications
You must be signed in to change notification settings - Fork 906
Move SidecarContainers to Beta #4361
Copy link
Copy link
Closed
Labels
area/user-experiencePertaining to developers trying to use Agones, e.g. SDK, installation, etcPertaining to developers trying to use Agones, e.g. SDK, installation, etcawaiting-maintainerBlock issues from being stale/obsolete/closedBlock issues from being stale/obsolete/closedgood first issueThese are great first issues. If you are looking for a place to start, start here!These are great first issues. If you are looking for a place to start, start here!help wantedWe would love help on these issues. Please come help us!We would love help on these issues. Please come help us!kind/breakingBreaking changeBreaking changekind/featureNew features for AgonesNew features for Agones
Metadata
Metadata
Assignees
Labels
area/user-experiencePertaining to developers trying to use Agones, e.g. SDK, installation, etcPertaining to developers trying to use Agones, e.g. SDK, installation, etcawaiting-maintainerBlock issues from being stale/obsolete/closedBlock issues from being stale/obsolete/closedgood first issueThese are great first issues. If you are looking for a place to start, start here!These are great first issues. If you are looking for a place to start, start here!help wantedWe would love help on these issues. Please come help us!We would love help on these issues. Please come help us!kind/breakingBreaking changeBreaking changekind/featureNew features for AgonesNew features for Agones
Is your feature request related to a problem? Please describe.
The
SidecarContainersfeature gate has been in Alpha since Agones v1.49.0. It refactors how the SDK server runs, utilizing Kubernetes native sidecar container support (or equivalent patterns) to decouple the SDK lifecycle from the GameServer container lifecycle.We have received no error reports since its introduction. However, this is a significant architectural change that affects GameServer Pod lifecycle and restart policies. Promoting it to Beta (enabled by default) is the necessary next step to validate its robustness across a wider range of user scenarios.
Describe the solution you'd like
I would like to promote
SidecarContainersto Beta.Following the feature stage progression steps defined in
pkg/util/runtime/features.go, the following changes are required:pkg/util/runtime/features.go: Change the default value ofSidecarContainerstotrue.SidecarContainersfeature gate in the docs and update as needed (e.g., removing instructions that imply it must be manually enabled, moving fromalphatobetashortcode, etc) (documentation contribution guide).Describe alternatives you've considered
Keeping it in Alpha. However, given the lack of bug reports, we need to move this to "Enabled by Default" to ensure it is battle-tested before eventually considering it for Stable.
Additional context
SidecarContainersRestartPolicybehavior and how the SDK sidecar interacts with the Game Server container. It is considered a breaking change for users relying on the legacy sidecar lifecycle behavior.