fix(gui): wasVisible-guard setGeometry in three more frameless toggles (#2603)#2635
Merged
Conversation
#2603) Follow-up to #2580. PropDashboardDialog, RadioSetupDialog, and PanFloatingWindow all reapplied geometry unconditionally after a flag change in setFramelessMode(), causing the same macOS cold-launch top-left placement bug fixed in the 5 dialogs touched by #2580. Wrap each setGeometry(geom) in `if (wasVisible)` so Qt's normal placement logic (centering on parent, restored last position, etc.) runs on first show, while runtime frameless toggles on already-visible dialogs still preserve geometry. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
#2603) Follow-up to #2580. PropDashboardDialog, RadioSetupDialog, and PanFloatingWindow all reapplied geometry unconditionally after a flag change in setFramelessMode(), causing the same macOS cold-launch top-left placement bug fixed in the 5 dialogs touched by #2580. Wrap each setGeometry(geom) in `if (wasVisible)` so Qt's normal placement logic (centering on parent, restored last position, etc.) runs on first show, while runtime frameless toggles on already-visible dialogs still preserve geometry. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
There was a problem hiding this comment.
LGTM — narrowly-scoped follow-up to #2618 that applies the documented frameless-toggle pattern (CLAUDE.md → docs/dialog-patterns.md: "restore geometry only if the window was already visible") to three more setFramelessMode implementations.
Verified against each file:
PanFloatingWindow.cpp:83—wasVisibleis already captured at line 74 and gates the trailingshow()at line 84. Adding the same gate tosetGeometryis the matching half of that pair.PropDashboardDialog.cpp:848—wasVisiblealready captured at line 843; them_titleBar/m_bodyLayoutadjustments below remain unconditional, which is correct (they're chrome-visibility, not window-geometry).RadioSetupDialog.cpp— same shape, same fix.
No out-of-scope changes, no QSettings usage introduced, no RAII or null-pointer concerns. Thanks for the quick follow-up.
ten9876
approved these changes
May 14, 2026
ten9876
left a comment
Collaborator
There was a problem hiding this comment.
Approved. Matches issue #2603 scope exactly — three named sites fixed correctly with the canonical wasVisible-guard pattern from #2580. Filing a follow-up for four additional sites the original catalog missed (ConnectionPanel, AetherialAudioStrip, FloatingContainerWindow frameless and always-on-top).
This was referenced May 14, 2026
ten9876
added a commit
that referenced
this pull request
May 15, 2026
…2646) (#2685) PRs #2580 and #2635 (closing #2603) applied the `if (wasVisible) setGeometry(geom)` guard across most `setFramelessMode(bool)` implementations. Four sites with the same code-shape were missed by both passes — fix listed in #2646: 1. ConnectionPanel::setFramelessMode 2. AetherialAudioStrip::setFramelessMode 3. FloatingContainerWindow::setFramelessMode 4. FloatingContainerWindow::setAlwaysOnTop All four captured `wasVisible` and `geom` early but called `setGeometry(geom)` unconditionally after `setWindowFlags(flags)`. On a cold-launched (never-shown) instance, `geom` is the default top-left rect and the unconditional `setGeometry` clobbers Qt's normal placement, leaving the window stuck at (0,0) on first show. Closes #2646. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2603
What was changed
fix(gui): wasVisible-guard setGeometry in three more frameless toggles (#2603)
Files modified
src/gui/PanFloatingWindow.cppsrc/gui/PropDashboardDialog.cppsrc/gui/RadioSetupDialog.cppGenerated by AetherClaude (automated agent for AetherSDR)