fix(gui): apply wasVisible-guard to four remaining setGeometry sites (#2646)#2685
Merged
Conversation
…2646) PRs #2580 and #2635 (closing #2603) applied the `if (wasVisible) setGeometry(geom)` guard across most `setFramelessMode(bool)` implementations. Four sites with the same code-shape were missed by both passes — fix listed in #2646: 1. ConnectionPanel::setFramelessMode 2. AetherialAudioStrip::setFramelessMode 3. FloatingContainerWindow::setFramelessMode 4. FloatingContainerWindow::setAlwaysOnTop All four captured `wasVisible` and `geom` early but called `setGeometry(geom)` unconditionally after `setWindowFlags(flags)`. On a cold-launched (never-shown) instance, `geom` is the default top-left rect and the unconditional `setGeometry` clobbers Qt's normal placement, leaving the window stuck at (0,0) on first show. Closes #2646. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs #2580 and #2635 (closing #2603) applied the
if (wasVisible) setGeometry(geom)guard across mostsetFramelessMode(bool)implementations. Four sites with the samecode-shape were missed by both passes — fix listed in #2646:
All four captured
wasVisibleandgeomearly but calledsetGeometry(geom)unconditionally aftersetWindowFlags(flags).On a cold-launched (never-shown) instance,
geomis the defaulttop-left rect and the unconditional
setGeometryclobbers Qt'snormal placement, leaving the window stuck at (0,0) on first show.
Closes #2646.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com