Sweep: 5 small bug-fixes (off-screen indicator, filter UX, RADE, spots, ATU)#2272
Merged
ten9876 merged 1 commit intoMay 2, 2026
Merged
Conversation
ten9876
commented
May 2, 2026
Collaborator
- Sweep: 7 small UI / contrast / indicator-routing fixes
- Sweep: 5 small bug-fixes (off-screen indicator, filter UX, RADE, spots, ATU)
…s, ATU) - Sweep: 7 small UI / contrast / indicator-routing fixes - Sweep: 5 small bug-fixes (off-screen indicator, filter UX, RADE, spots, ATU)
This was referenced May 2, 2026
ten9876
added a commit
that referenced
this pull request
May 2, 2026
Reliability sweep release. Headline is jensenpat's DAX2 coexistence policy refactor (#2271): platform-aware decision table, lazy dax_tx stream creation, anti-stomp on incoming foreign DAX TX status, LAN VITA UDP rebind on Flex's "Port/IP pair already in use" error, dead- orphan DAX RX detection, and 24+ test assertions. Substantial reliability fixes around disconnect teardown (#2247 — sequenced stream remove with response wait, dropped self-disconnect, dying-gasp byte), worker-thread shutdown (#2248 — no more killTimer warnings), and panadapter zoom (#2246 — no spectrum flash). Closes 12 issues via two paired triage-cleanup sweep PRs (#2270 + #2272) covering small UI bugs, contrast, indicator routing, click-to- tune behaviour, and visible regressions from recent feature work. Also includes the #2273 follow-up to #2271: setDax() and DAX TX stream creation are now both gated on platforms that can actually feed DAX audio, so Linux non-PipeWire builds keep digital TX on the physical mic input rather than going silent. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
2 tasks
aethersdr-agent Bot
added a commit
that referenced
this pull request
May 24, 2026
…margin (#2941). Principle XI. Single-click on the off-screen slice indicator (the "C> 3.777" / "<B 3.573" chevrons in the panadapter corner) reaches MainWindow::revealFrequencyIfNeeded with TuneIntent::RevealOffscreen, where the comfort margin was hard-coded to 0.0 — settling the slice exactly on the visible edge. The result is partially clipped and indistinguishable from "still off-screen" to the user, which is the behavior #2371 / #2941 reports. Switch the RevealOffscreen branch to kRevealComfortEdgeMarginFrac (0.18, the same constant used for non-click reveals), so the slice lands ~18% in from the edge instead of straddling it. Smallest defensible fix per the issue triage (Option B); does not alter the documented single-click vs. double-click split introduced by #2272 (double-click still hard-centers). The previous closure of #2371 ("Closed in #2272") was premature: #2272 added the double-click hard-center path but left the single-click reveal-to-edge behavior intact. Citing Principle XI: that earlier "Fixes #2371" claim was undemonstrated against the original reporter's repro, so the bug came back under a new number; this PR is the actual demonstration. Blast radius: risk_score=0.484, 14 high-risk affected (top: AppSettings::instance, MainWindow::MainWindow, AppSettings::value). Reviewed: the only call site passing TuneIntent::RevealOffscreen is MainWindow::setActiveSliceInternal (src/gui/MainWindow.cpp:10721), which is itself only triggered by the SpectrumWidget::sliceClicked signal — i.e. the off-screen-indicator click flow. Other callers of revealFrequencyIfNeeded pass CommandedTargetCenter (hard-center, returns early) or IncrementalTune (uses its own incremental margins, ignores comfortMargin), so the wide upstream caller surface is unaffected by this change. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.