Skip to content

Sweep: 5 small bug-fixes (off-screen indicator, filter UX, RADE, spots, ATU)#2272

Merged
ten9876 merged 1 commit into
mainfrom
auto/Sweep-5-small-bug-fixes-off-screen-indicator-filte
May 2, 2026
Merged

Sweep: 5 small bug-fixes (off-screen indicator, filter UX, RADE, spots, ATU)#2272
ten9876 merged 1 commit into
mainfrom
auto/Sweep-5-small-bug-fixes-off-screen-indicator-filte

Conversation

@ten9876

@ten9876 ten9876 commented May 2, 2026

Copy link
Copy Markdown
Collaborator
  • Sweep: 7 small UI / contrast / indicator-routing fixes
  • Sweep: 5 small bug-fixes (off-screen indicator, filter UX, RADE, spots, ATU)

…s, ATU)

- Sweep: 7 small UI / contrast / indicator-routing fixes
- Sweep: 5 small bug-fixes (off-screen indicator, filter UX, RADE, spots, ATU)
@ten9876 ten9876 requested a review from jensenpat as a code owner May 2, 2026 04:08
@ten9876 ten9876 enabled auto-merge (squash) May 2, 2026 04:08
@ten9876 ten9876 merged commit 8a0a42e into main May 2, 2026
7 of 8 checks passed
@ten9876 ten9876 deleted the auto/Sweep-5-small-bug-fixes-off-screen-indicator-filte branch May 2, 2026 04:32
ten9876 added a commit that referenced this pull request May 2, 2026
Reliability sweep release.  Headline is jensenpat's DAX2 coexistence
policy refactor (#2271): platform-aware decision table, lazy dax_tx
stream creation, anti-stomp on incoming foreign DAX TX status, LAN
VITA UDP rebind on Flex's "Port/IP pair already in use" error, dead-
orphan DAX RX detection, and 24+ test assertions.

Substantial reliability fixes around disconnect teardown (#2247 —
sequenced stream remove with response wait, dropped self-disconnect,
dying-gasp byte), worker-thread shutdown (#2248 — no more killTimer
warnings), and panadapter zoom (#2246 — no spectrum flash).

Closes 12 issues via two paired triage-cleanup sweep PRs (#2270 +
#2272) covering small UI bugs, contrast, indicator routing, click-to-
tune behaviour, and visible regressions from recent feature work.

Also includes the #2273 follow-up to #2271: setDax() and DAX TX
stream creation are now both gated on platforms that can actually
feed DAX audio, so Linux non-PipeWire builds keep digital TX on the
physical mic input rather than going silent.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
aethersdr-agent Bot added a commit that referenced this pull request May 24, 2026
…margin (#2941). Principle XI.

Single-click on the off-screen slice indicator (the "C> 3.777" / "<B 3.573"
chevrons in the panadapter corner) reaches MainWindow::revealFrequencyIfNeeded
with TuneIntent::RevealOffscreen, where the comfort margin was hard-coded to
0.0 — settling the slice exactly on the visible edge.  The result is partially
clipped and indistinguishable from "still off-screen" to the user, which is
the behavior #2371 / #2941 reports.

Switch the RevealOffscreen branch to kRevealComfortEdgeMarginFrac (0.18, the
same constant used for non-click reveals), so the slice lands ~18% in from the
edge instead of straddling it.  Smallest defensible fix per the issue triage
(Option B); does not alter the documented single-click vs. double-click split
introduced by #2272 (double-click still hard-centers).

The previous closure of #2371 ("Closed in #2272") was premature: #2272 added
the double-click hard-center path but left the single-click reveal-to-edge
behavior intact.  Citing Principle XI: that earlier "Fixes #2371" claim was
undemonstrated against the original reporter's repro, so the bug came back
under a new number; this PR is the actual demonstration.

Blast radius: risk_score=0.484, 14 high-risk affected (top: AppSettings::instance,
MainWindow::MainWindow, AppSettings::value).  Reviewed: the only call site
passing TuneIntent::RevealOffscreen is MainWindow::setActiveSliceInternal
(src/gui/MainWindow.cpp:10721), which is itself only triggered by the
SpectrumWidget::sliceClicked signal — i.e. the off-screen-indicator click
flow.  Other callers of revealFrequencyIfNeeded pass CommandedTargetCenter
(hard-center, returns early) or IncrementalTune (uses its own incremental
margins, ignores comfortMargin), so the wide upstream caller surface is
unaffected by this change.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant