[memory] Restore repeater offset, tone details on memory recall#2080
Merged
ten9876 merged 1 commit intoApr 27, 2026
Merged
Conversation
ten9876
added a commit
that referenced
this pull request
Apr 27, 2026
Local iambic CW keyer (#2079), unified sidetone controls, CW pan slider wiring, slice capacity notification (#48), three latent netcw protocol bugs that prevented CW transmit on FLEX-8600 v4.1.5 firmware, optimistic updates for cwIambic/iambicMode/cwSpeed/cwPitch, PortAudio JACK preference for sub-5 ms sidetone on Linux, plus the graceful disconnect (#1997), memory recall (#2080), per-slice compression meter (#2073), and m_activeTxSlice (#2078) fixes from the community. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory applytx_offset_freqfrom the recalled memory direction/offset so stale transmit offsets are clearedRoot Cause
The radio restores memory fields like repeater direction and offset during recall, but the derived slice field
tx_offset_freqcan remain stale. Both quick recall and the Memory dialog route throughMainWindow::activateMemorySpot(), so the fix-up lives there and applies to both paths.Validation
./build/memory_recall_policy_testcmake --build build -j 10Fixes #1871
Fixes #1965
👨🏼💻 Generated with OpenAI Codex (GPT-5.5 Pro 4/23) and tested by @jensenpat