Triage analysis

Root cause

When a memory is recalled via activateMemorySpot() (src/gui/MainWindow.cpp:6536), the code sends memory apply <index> to the radio and then explicitly re-sends only the tuning step as a client-side fixup (lines 6583–6585). However, the tx_offset_freq — the actual transmit offset that determines where the radio transmits relative to the receive frequency — is never recomputed or sent.

The tx_offset_freq is a derived value: when the user manually sets the repeater direction via the UI buttons, RxApplet::applyOffsetDir() (src/gui/RxApplet.cpp:1795) computes it from repeater_offset_dir and fm_repeater_offset_freq:

direction "up" → tx_offset_freq = +offset
direction "down" → tx_offset_freq = -offset
direction "simplex" → tx_offset_freq = 0

During memory recall, the radio's memory apply sets the slice's repeater_offset_dir and fm_repeater_offset_freq correctly, but nobody triggers the equivalent tx_offset_freq computation. The slice ends up with the correct offset direction shown in the UI but the wrong (stale) transmit offset — so the radio would transmit on the wrong frequency.

Additionally, tx_offset_freq is not stored in MemoryEntry at all and is not included in buildMemoryUpdateData(), so the radio-side memory doesn't carry it either.

Proposed fix

In MainWindow::activateMemorySpot() (src/gui/MainWindow.cpp), after the existing step fixup (line 6583–6585), add a tx_offset_freq fixup that mirrors the logic in RxApplet::applyOffsetDir():

// Recompute tx_offset_freq from the memory's repeater direction + offset
if (!it->offsetDir.isEmpty()) {
    double txOffset = 0.0;
    if (it->offsetDir == "up")
        txOffset = it->repeaterOffset;
    else if (it->offsetDir == "down")
        txOffset = -it->repeaterOffset;
    m_radioModel.sendCommand(QString("slice set %1 repeater_offset_dir=%2 fm_repeater_offset_freq=%3 tx_offset_freq=%4")
        .arg(sliceId)
        .arg(it->offsetDir)
        .arg(it->repeaterOffset, 0, 'f', 6)
        .arg(txOffset, 0, 'f', 6));
}

This explicitly sends all three fields (repeater_offset_dir, fm_repeater_offset_freq, and the derived tx_offset_freq) to the slice after the radio has applied the memory, ensuring the transmit offset matches the stored memory regardless of what memory apply does or doesn't push back.

Files to change: src/gui/MainWindow.cpp — activateMemorySpot(), ~5 lines added after the step fixup block.

Questions for the reporter

Can you confirm you're seeing this specifically with FM repeater memories (i.e., memories stored with offset direction set to "up" or "down")?
After recalling the memory, does the offset direction indicator in the RX panel show the correct direction (e.g., "−" or "+") even though transmit goes to the wrong frequency? That would confirm it's specifically tx_offset_freq that's stale rather than the direction/offset not being applied at all.
Does the issue reproduce every time, or only when recalling a memory whose offset direction differs from the slice's current setting?

Uh oh!

Memory recall not setting the repeater offset correctly #1965

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions