Skip to content

Fix audio stopping after idle/screensaver with USB audio devices#1376

Merged
ten9876 merged 1 commit into
mainfrom
fix-usb-audio-idle
Apr 14, 2026
Merged

Fix audio stopping after idle/screensaver with USB audio devices#1376
ten9876 merged 1 commit into
mainfrom
fix-usb-audio-idle

Conversation

@ten9876

@ten9876 ten9876 commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Monitor audio device list changes to restart RX on USB device power-cycle
  • Zombie sink watchdog: detect stale WASAPI handle (bytesFree stuck at 0)
  • Handle IdleState in addition to StoppedState for stale session detection

Fixes #1361. From AetherClaude PR #1363.

🤖 Generated with Claude Code

Add three recovery mechanisms for when Windows WASAPI audio sessions go
stale after idle/screensaver, which Qt's QAudioSink doesn't detect:

1. QMediaDevices::audioOutputsChanged listener — restarts the RX stream
   when USB audio devices (like Connect6) power-cycle or re-enumerate.

2. Zombie sink watchdog in the RX pacing timer — detects when bytesFree()
   is stuck at 0 for ~2 seconds while data is waiting, indicating a stale
   WASAPI handle, and forces a restart.

3. IdleState handling in stateChanged — catches the case where the sink
   transitions to Idle (not Stopped) with pending data, which the
   existing #1303 recovery missed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ten9876 ten9876 merged commit 05663e8 into main Apr 14, 2026
3 checks passed
@ten9876 ten9876 deleted the fix-usb-audio-idle branch April 14, 2026 15:32
@scott-mss

Copy link
Copy Markdown

Nice, thank you.

chibondking pushed a commit to chibondking/AetherSDR that referenced this pull request Apr 14, 2026
…hersdr#1361) (aethersdr#1376)

Add three recovery mechanisms for when Windows WASAPI audio sessions go
stale after idle/screensaver, which Qt's QAudioSink doesn't detect:

1. QMediaDevices::audioOutputsChanged listener — restarts the RX stream
   when USB audio devices (like Connect6) power-cycle or re-enumerate.

2. Zombie sink watchdog in the RX pacing timer — detects when bytesFree()
   is stuck at 0 for ~2 seconds while data is waiting, indicating a stale
   WASAPI handle, and forces a restart.

3. IdleState handling in stateChanged — catches the case where the sink
   transitions to Idle (not Stopped) with pending data, which the
   existing aethersdr#1303 recovery missed.

Co-authored-by: AetherClaude <aetherclaude@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@aethersdr-agent aethersdr-agent Bot mentioned this pull request Apr 14, 2026
2 tasks
aethersdr-agent Bot pushed a commit that referenced this pull request Apr 14, 2026
…1405)

The IdleState handler added in #1376 for stale WASAPI session recovery
was triggering a continuous stop/start loop during normal playback on
Windows. In Qt6 push-mode QAudioSink, IdleState fires whenever the
internal buffer drains between write ticks — this is normal behavior,
not an error. The handler misidentified it as a stale session and
restarted the sink, preventing audio from ever playing.

The existing zombie sink watchdog (bytesFree() stuck at 0 for ~2s)
already covers the original #1361 idle/screensaver recovery scenario.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@aethersdr-agent aethersdr-agent Bot mentioned this pull request Apr 14, 2026
2 tasks
ten9876 pushed a commit that referenced this pull request Apr 14, 2026
…1405)

The IdleState handler added in #1376 for stale WASAPI session recovery
was triggering a continuous stop/start loop during normal playback on
Windows. In Qt6 push-mode QAudioSink, IdleState fires whenever the
internal buffer drains between write ticks — this is normal behavior,
not an error. The handler misidentified it as a stale session and
restarted the sink, preventing audio from ever playing.

The existing zombie sink watchdog (bytesFree() stuck at 0 for ~2s)
already covers the original #1361 idle/screensaver recovery scenario.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ten9876 added a commit that referenced this pull request Apr 14, 2026
…1405) (#1419)

The IdleState handler added in #1376 for stale WASAPI session recovery
was triggering a continuous stop/start loop during normal playback on
Windows. In Qt6 push-mode QAudioSink, IdleState fires whenever the
internal buffer drains between write ticks — this is normal behavior,
not an error. The handler misidentified it as a stale session and
restarted the sink, preventing audio from ever playing.

The existing zombie sink watchdog (bytesFree() stuck at 0 for ~2s)
already covers the original #1361 idle/screensaver recovery scenario.

Co-authored-by: AetherClaude <aetherclaude@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sound through AetherSDR stops working, have to close and reopen ADR to get it to work again.

3 participants