Fix audio stopping after idle/screensaver with USB audio devices#1376
Merged
Conversation
Add three recovery mechanisms for when Windows WASAPI audio sessions go stale after idle/screensaver, which Qt's QAudioSink doesn't detect: 1. QMediaDevices::audioOutputsChanged listener — restarts the RX stream when USB audio devices (like Connect6) power-cycle or re-enumerate. 2. Zombie sink watchdog in the RX pacing timer — detects when bytesFree() is stuck at 0 for ~2 seconds while data is waiting, indicating a stale WASAPI handle, and forces a restart. 3. IdleState handling in stateChanged — catches the case where the sink transitions to Idle (not Stopped) with pending data, which the existing #1303 recovery missed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Nice, thank you. |
chibondking
pushed a commit
to chibondking/AetherSDR
that referenced
this pull request
Apr 14, 2026
…hersdr#1361) (aethersdr#1376) Add three recovery mechanisms for when Windows WASAPI audio sessions go stale after idle/screensaver, which Qt's QAudioSink doesn't detect: 1. QMediaDevices::audioOutputsChanged listener — restarts the RX stream when USB audio devices (like Connect6) power-cycle or re-enumerate. 2. Zombie sink watchdog in the RX pacing timer — detects when bytesFree() is stuck at 0 for ~2 seconds while data is waiting, indicating a stale WASAPI handle, and forces a restart. 3. IdleState handling in stateChanged — catches the case where the sink transitions to Idle (not Stopped) with pending data, which the existing aethersdr#1303 recovery missed. Co-authored-by: AetherClaude <aetherclaude@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
aethersdr-agent Bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
…1405) The IdleState handler added in #1376 for stale WASAPI session recovery was triggering a continuous stop/start loop during normal playback on Windows. In Qt6 push-mode QAudioSink, IdleState fires whenever the internal buffer drains between write ticks — this is normal behavior, not an error. The handler misidentified it as a stale session and restarted the sink, preventing audio from ever playing. The existing zombie sink watchdog (bytesFree() stuck at 0 for ~2s) already covers the original #1361 idle/screensaver recovery scenario. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ten9876
pushed a commit
that referenced
this pull request
Apr 14, 2026
…1405) The IdleState handler added in #1376 for stale WASAPI session recovery was triggering a continuous stop/start loop during normal playback on Windows. In Qt6 push-mode QAudioSink, IdleState fires whenever the internal buffer drains between write ticks — this is normal behavior, not an error. The handler misidentified it as a stale session and restarted the sink, preventing audio from ever playing. The existing zombie sink watchdog (bytesFree() stuck at 0 for ~2s) already covers the original #1361 idle/screensaver recovery scenario. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ten9876
added a commit
that referenced
this pull request
Apr 14, 2026
…1405) (#1419) The IdleState handler added in #1376 for stale WASAPI session recovery was triggering a continuous stop/start loop during normal playback on Windows. In Qt6 push-mode QAudioSink, IdleState fires whenever the internal buffer drains between write ticks — this is normal behavior, not an error. The handler misidentified it as a stale session and restarted the sink, preventing audio from ever playing. The existing zombie sink watchdog (bytesFree() stuck at 0 for ~2s) already covers the original #1361 idle/screensaver recovery scenario. Co-authored-by: AetherClaude <aetherclaude@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1361. From AetherClaude PR #1363.
🤖 Generated with Claude Code