Remove IdleState restart logic that caused audio silence on Windows#1419
Merged
Conversation
…1405) The IdleState handler added in #1376 for stale WASAPI session recovery was triggering a continuous stop/start loop during normal playback on Windows. In Qt6 push-mode QAudioSink, IdleState fires whenever the internal buffer drains between write ticks — this is normal behavior, not an error. The handler misidentified it as a stale session and restarted the sink, preventing audio from ever playing. The existing zombie sink watchdog (bytesFree() stuck at 0 for ~2s) already covers the original #1361 idle/screensaver recovery scenario. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1405. From AetherClaude PR #1408.
🤖 Generated with Claude Code