Merged
Conversation
# Conflicts: # README.md
# Conflicts: # code/AdobeEdge.brs # code/components/adobe/AdobeEdgeTask.brs # code/tests/adb_test_AdobeEdge_AdobeSDKInit.brs # sample/simple-videoplayer-channel/components/SimpleVideoScene.brs # sample/simple-videoplayer-channel/source/main.brs
# Conflicts: # code/AdobeEdge.brs # code/tests/adb_test_AdobeEdge_public_APIs.brs # sample/simple-videoplayer-channel/source/main.brs
# Conflicts: # code/AdobeEdge.brs # code/components/adobe/AdobeEdgeTask.brs # code/tests/adb_test_AdobeEdge.brs # code/tests/adb_test_AdobeEdge_EventProcessor.brs # sample/simple-videoplayer-channel/source/main.brs
yangyansong-adbe
added a commit
that referenced
this pull request
Aug 3, 2023
* Initialize Roku SDK project with unit tests and the test/sample app (#5) * add project intro * Update README.md * Roku SDK init * tmp * remove implementation * tmp * draft * update Makefile * it works * tmp * it works * tmp * add API docs * make file * Create node.js.yml * no message * no message * test * 1 * 2 * 3 * no message * no message * cleanup * remove unused code * Add more tests (#6) * add project intro * Update README.md * Roku SDK init * tmp * remove implementation * tmp * draft * update Makefile * it works * tmp * it works * tmp * add API docs * make file * Create node.js.yml * no message * no message * test * 1 * 2 * 3 * no message * no message * cleanup * remove unused code * tmp * support first-party domain * Add more tests and code refactor (#7) * add project intro * Update README.md * Roku SDK init * tmp * remove implementation * tmp * draft * update Makefile * it works * tmp * it works * tmp * add API docs * make file * Create node.js.yml * no message * no message * test * 1 * 2 * 3 * no message * no message * cleanup * remove unused code * tmp * support first-party domain * add more tests * add tests * small refactor * syntax fix * remove key * Code Reactor - part I (#8) * add project intro * Update README.md * Roku SDK init * tmp * remove implementation * tmp * draft * update Makefile * it works * tmp * it works * tmp * add API docs * make file * Create node.js.yml * no message * no message * test * 1 * 2 * 3 * no message * no message * cleanup * remove unused code * tmp * support first-party domain * add more tests * add tests * small refactor * syntax fix * remove key * tmp * tmp * cleanup * clean up (#9) * Create getting-started.md * Create README.md * Code refactoring - part III (#11) * code refactoring * remove id * Fixed issue when generating ECID for invalid edge configId. (#12) * Fixed issue when generating ECID for invalid edge configId. Fix couple of minor issues and did some refactoring. * Refactored ECID generation and storage logic to stateManager. Modified log format. * Fixes to ECID logic * Cleanup code * Refactor buildEdgeRequestURL function (#13) * add tests for "_adb_isEmptyOrInvalidString" (#15) * add tests for _adb_isNullOrEmptyString * update the function name * Add Issue template and SECURITY.md files. (#16) * add tests for "_adb_buildEdgeRequestURL" (#19) * Add resetIdentities API. Also added map utils and refactored code. (#20) * Add resetIdentities API. Also added map utils and refactored code. * review fixes * Add tests for "_adb_EdgeRequestWorker" (#18) * tmp * add tests for EdgeRequestWorker * address review comments * Update AdobeEdge.brs * Update AdobeEdge.brs * address review comments * Add tests for StateManager (#24) * Add tests for StateManager * Remove unwanted helper * Add more tests for "_adb_EdgeRequestWorker" (#21) * add more tests for RequestWorker * fix typo * Add more tests for "EventProcessor" (#22) * more tests * rename private fields * address review comments * address review comments * Quick bug fix (#26) * quickly fix several issues. * remove unused. * rename a function * fix tests * rename a function * Update configuration format same as Tags + Fix issue in using edge.domain value from configuration (#28) * Update configuration format to match the launch config * Fix an issue with populating edge.domain value from configuration * Validate domain name using regex * Move domain validation to stateManager * Show timestamp in logs (#27) * Show timestamp for each logging message * add timestamp to logs * show timestamp in logs by default * Fixed several issues (#29) * fix xdm data format issue * fix query data format issue * minor fixes * clean up and bug fix * remove unused functions * not to kick off request processing if config id is invalid * miss the return valuse * address review comments * code refactoring * no message * debug -> verbose * update API doc for updateConfiguration --------- Co-authored-by: Arjun Bhadra <abhadra@adobe.com> * Update API reference (#30) * Update API reference * Format updates * Updates based on reviews * Update documentation/Makefile (#14) * tmp * version * Update getting-started.md * address review comments * update API doc * Update api-reference.md * Update api-reference.md * Update getting-started.md * Update getting-started.md * address review comments * Address review comments * Code and log refactoring + cleanup (#34) * Sample app cleanup (#33) * sample app cleanup * address review comments * Fix tests (#35) * sample app cleanup * tmp * Update public API name to sendEvent() (#36) * Update public API name to sendEvent() * Updates based on reviews * More review updates * Fixes in handling callback timeout (#37) * Added null check before handling callback timeout * Add settings for profiling sample channel * Update Documentation (#38) * Update SDK names and references * format and typo update * Updates based on reviews * Format updates and minor rewording * minor update * Minor reword * Minor rewording for sendEvent API * Add sample for implementationDetails * Updates based on reviews * Update wordings for setECID API * Update format * Update code format * Update code snippet for implementationDetails * Update wording * update minor wording * Split SDK file into multiple source files (#41) * tmp * Split SDK * project cleanup * cleanup the dev app * cleanup * remove unused * update README * clean up the sample app and updated the CI * fix CI and do more cleanup * build script refactoring * rename files * rename files * address review comments * address review comments * address one comment * Project refactoring (#50) * Rename vars and functions (#46) * rename internal vars/functions * use short name * refactor task node logic (#47) * Modularize event processing (#48) * modularize event processing * add more modules * more cleanup * unify the internal generated objects * tmp * refactor unit tests * refactor tests * integration test setup (part I) (#51) * integration test setup (part I) * cleanup * add more tests * fix CI issue * move ADBTestRunner to a separate source file * To launch the dev channel, activate "Conditional Compilation" for the following purposes: - Conducting unit testing - Performing integration testing - Carrying out manual testing * address review comments * update test case : TC_SDK_sendEvent * small cleanup (#52) * Refactored code to simply logic (#53) * Refactored Identity and other modules + ECID not primary in IdentityMap by default (#55) * Refactored Identity and other modules * More cleanup * More updates * integration test (part II) (#54) * fix a couple issues * add more integration tests * bug fix: repeatedly calling shutdown API can lead to problems. * Fix test failure (#58) * fix a couple issues * add more integration tests * bug fix: repeatedly calling shutdown API can lead to problems. * address review comments * Added logic to wait before retrying requests failed with recoverable error (#59) * Added logic to wait before retrying requests failed with recoverable error * Update wait time to 30 seconds. * Force retry hits when new hit is queued * Add unit test for retry wait logic * Update integration tests to test the identity map * Update and cleanup integration tests * Remove unwanted helper * Scripts to create Release artifacts (#62) * Added script to release using github actions * Add script to verify release version with source code version * Update release branch to main * Update sample app scripts and renamed build workflow * Updates based on reviews * assign shell value in github action * Update version script * try a fix * Added script to extract version * Fix scripts * Change branch to main for release * Update the dev channel for manual testing (#61) * enable app profiling * update dev app for manual testing * address review comments * remove unused code * cleanup * Added a step to the readme for linking the SDK to the development app * Build/release scripts enhancement (#63) * merge brs source files in a special order * build script cleanup and add the sample channel to the release page * switch release branch to main * fix release action format * fix an issue in version.sh * release action cleanup * Address review comments (#65) * Update doc with IdentityMap sample (#64) * Update doc with IdentityMap sample * Update wording * Fix typo in sample * More changes and restructuring * Updates based on reviews * More updates * Format updates * update wording * Update based on reviews * Refactored code to rename based on AEPRokuSDK branding. (#68) * Refactored code to rename based on AEPRokuSDK branding. * update gitignore * Address several review comments and add a missing test case. (#69) * address several review comments and add a missing test case. * update the API docs for sendEvent * Update test_public_APIs.brs --------- Co-authored-by: Arjun Bhadra <arjun.d.bhadra@gmail.com> Co-authored-by: Arjun Bhadra <abhadra@adobe.com> Co-authored-by: Brandon Pack <bpack@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: