Skip to content

Dev -> Staging for Roku SDK 1.0.0#67

Merged
yangyansong-adbe merged 47 commits intostagingfrom
dev
Aug 3, 2023
Merged

Dev -> Staging for Roku SDK 1.0.0#67
yangyansong-adbe merged 47 commits intostagingfrom
dev

Conversation

@yangyansong-adbe
Copy link
Copy Markdown
Contributor

No description provided.

yangyansong-adbe and others added 30 commits June 15, 2023 15:00
* add project intro

* Update README.md

* Roku SDK init

* tmp

* remove implementation

* tmp

* draft

* update Makefile

* it works

* tmp

* it works

* tmp

* add API docs

* make file

* Create node.js.yml

* no message

* no message

* test

* 1

* 2

* 3

* no message

* no message

* cleanup

* remove unused code
* add project intro

* Update README.md

* Roku SDK init

* tmp

* remove implementation

* tmp

* draft

* update Makefile

* it works

* tmp

* it works

* tmp

* add API docs

* make file

* Create node.js.yml

* no message

* no message

* test

* 1

* 2

* 3

* no message

* no message

* cleanup

* remove unused code

* tmp

* support first-party domain
* add project intro

* Update README.md

* Roku SDK init

* tmp

* remove implementation

* tmp

* draft

* update Makefile

* it works

* tmp

* it works

* tmp

* add API docs

* make file

* Create node.js.yml

* no message

* no message

* test

* 1

* 2

* 3

* no message

* no message

* cleanup

* remove unused code

* tmp

* support first-party domain

* add more tests

* add tests

* small refactor

* syntax fix

* remove key
* add project intro

* Update README.md

* Roku SDK init

* tmp

* remove implementation

* tmp

* draft

* update Makefile

* it works

* tmp

* it works

* tmp

* add API docs

* make file

* Create node.js.yml

* no message

* no message

* test

* 1

* 2

* 3

* no message

* no message

* cleanup

* remove unused code

* tmp

* support first-party domain

* add more tests

* add tests

* small refactor

* syntax fix

* remove key

* tmp

* tmp

* cleanup
* code refactoring

* remove id
* Fixed issue when generating ECID for invalid edge configId. Fix couple of minor issues and did some refactoring.

* Refactored ECID generation and storage logic to stateManager. Modified log format.

* Fixes to ECID logic

* Cleanup code
* add tests for _adb_isNullOrEmptyString

* update the function name
* Add resetIdentities API. Also added map utils and refactored code.

* review fixes
* tmp

* add tests for EdgeRequestWorker

* address review comments

* Update AdobeEdge.brs

* Update AdobeEdge.brs

* address review comments
* Add tests for StateManager

* Remove unwanted helper
* add more tests for RequestWorker

* fix typo
* more tests

* rename private fields

* address review comments

* address review comments
* quickly fix several issues.

* remove unused.

* rename a function

* fix tests

* rename a function
…main value from configuration (#28)

* Update configuration format to match the launch config

* Fix an issue with populating edge.domain value from configuration

* Validate domain name using regex

* Move domain validation to stateManager
* Show timestamp for each logging message

* add timestamp to logs

* show timestamp in logs by default
* fix xdm data format issue

* fix query data format issue

* minor fixes

* clean up and bug fix

* remove unused functions

* not to kick off request processing if config id is invalid

* miss the return valuse

* address review comments

* code refactoring

* no message

* debug -> verbose

* update API doc for updateConfiguration

---------

Co-authored-by: Arjun Bhadra <abhadra@adobe.com>
* Update API reference

* Format updates

* Updates based on reviews
* tmp

* version

* Update getting-started.md

* address review comments

* update API doc

* Update api-reference.md

* Update api-reference.md

* Update getting-started.md

* Update getting-started.md

* address review comments

* Address review comments
* sample app cleanup

* address review comments
* sample app cleanup

* tmp
* Update public API name to sendEvent()

* Updates based on reviews

* More review updates
* Added null check before handling callback timeout

* Add settings for profiling sample channel
* Update SDK names and references

* format and typo update

* Updates based on reviews

* Format updates and minor rewording

* minor update

* Minor reword

* Minor rewording for sendEvent API

* Add sample for implementationDetails

* Updates based on reviews

* Update wordings for setECID API

* Update format

* Update code format

* Update code snippet for implementationDetails

* Update wording

* update minor wording
@yangyansong-adbe yangyansong-adbe marked this pull request as ready for review August 2, 2023 21:33
@yangyansong-adbe yangyansong-adbe requested a review from addb August 2, 2023 21:33
addb added 2 commits August 2, 2023 14:36
* Update doc with IdentityMap sample

* Update wording

* Fix typo in sample

* More changes and restructuring

* Updates based on reviews

* More updates

* Format updates

* update wording

* Update based on reviews
* Refactored code to rename based on AEPRokuSDK branding.

* update gitignore
Copy link
Copy Markdown
Contributor

@addb addb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments

* address several review comments and add a missing test case.

* update the API docs for sendEvent

* Update test_public_APIs.brs
@yangyansong-adbe yangyansong-adbe merged commit 9fbb1b1 into staging Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants