Dev -> Staging for Roku SDK 1.0.0#67
Merged
yangyansong-adbe merged 47 commits intostagingfrom Aug 3, 2023
Merged
Conversation
* add project intro * Update README.md * Roku SDK init * tmp * remove implementation * tmp * draft * update Makefile * it works * tmp * it works * tmp * add API docs * make file * Create node.js.yml * no message * no message * test * 1 * 2 * 3 * no message * no message * cleanup * remove unused code
* add project intro * Update README.md * Roku SDK init * tmp * remove implementation * tmp * draft * update Makefile * it works * tmp * it works * tmp * add API docs * make file * Create node.js.yml * no message * no message * test * 1 * 2 * 3 * no message * no message * cleanup * remove unused code * tmp * support first-party domain
* add project intro * Update README.md * Roku SDK init * tmp * remove implementation * tmp * draft * update Makefile * it works * tmp * it works * tmp * add API docs * make file * Create node.js.yml * no message * no message * test * 1 * 2 * 3 * no message * no message * cleanup * remove unused code * tmp * support first-party domain * add more tests * add tests * small refactor * syntax fix * remove key
* add project intro * Update README.md * Roku SDK init * tmp * remove implementation * tmp * draft * update Makefile * it works * tmp * it works * tmp * add API docs * make file * Create node.js.yml * no message * no message * test * 1 * 2 * 3 * no message * no message * cleanup * remove unused code * tmp * support first-party domain * add more tests * add tests * small refactor * syntax fix * remove key * tmp * tmp * cleanup
* code refactoring * remove id
* Fixed issue when generating ECID for invalid edge configId. Fix couple of minor issues and did some refactoring. * Refactored ECID generation and storage logic to stateManager. Modified log format. * Fixes to ECID logic * Cleanup code
* add tests for _adb_isNullOrEmptyString * update the function name
* Add resetIdentities API. Also added map utils and refactored code. * review fixes
* tmp * add tests for EdgeRequestWorker * address review comments * Update AdobeEdge.brs * Update AdobeEdge.brs * address review comments
* Add tests for StateManager * Remove unwanted helper
* add more tests for RequestWorker * fix typo
* more tests * rename private fields * address review comments * address review comments
* quickly fix several issues. * remove unused. * rename a function * fix tests * rename a function
…main value from configuration (#28) * Update configuration format to match the launch config * Fix an issue with populating edge.domain value from configuration * Validate domain name using regex * Move domain validation to stateManager
* Show timestamp for each logging message * add timestamp to logs * show timestamp in logs by default
* fix xdm data format issue * fix query data format issue * minor fixes * clean up and bug fix * remove unused functions * not to kick off request processing if config id is invalid * miss the return valuse * address review comments * code refactoring * no message * debug -> verbose * update API doc for updateConfiguration --------- Co-authored-by: Arjun Bhadra <abhadra@adobe.com>
* Update API reference * Format updates * Updates based on reviews
* tmp * version * Update getting-started.md * address review comments * update API doc * Update api-reference.md * Update api-reference.md * Update getting-started.md * Update getting-started.md * address review comments * Address review comments
* sample app cleanup * address review comments
* sample app cleanup * tmp
* Update public API name to sendEvent() * Updates based on reviews * More review updates
* Added null check before handling callback timeout * Add settings for profiling sample channel
* Update SDK names and references * format and typo update * Updates based on reviews * Format updates and minor rewording * minor update * Minor reword * Minor rewording for sendEvent API * Add sample for implementationDetails * Updates based on reviews * Update wordings for setECID API * Update format * Update code format * Update code snippet for implementationDetails * Update wording * update minor wording
* Update doc with IdentityMap sample * Update wording * Fix typo in sample * More changes and restructuring * Updates based on reviews * More updates * Format updates * update wording * Update based on reviews
* Refactored code to rename based on AEPRokuSDK branding. * update gitignore
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
addb
reviewed
Aug 3, 2023
sample/simple-videoplayer-channel/components/SimpleVideoScene.brs
Outdated
Show resolved
Hide resolved
addb
reviewed
Aug 3, 2023
* address several review comments and add a missing test case. * update the API docs for sendEvent * Update test_public_APIs.brs
addb
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.