Skip to content

Some cleanup#137

Merged
yangyansong-adbe merged 1 commit intoadobe:nonXdmDataSupportfrom
yangyansong-adbe:cleanup
Jan 8, 2024
Merged

Some cleanup#137
yangyansong-adbe merged 1 commit intoadobe:nonXdmDataSupportfrom
yangyansong-adbe:cleanup

Conversation

@yangyansong-adbe
Copy link
Copy Markdown
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yangyansong-adbe yangyansong-adbe merged commit c77beb2 into adobe:nonXdmDataSupport Jan 8, 2024
yangyansong-adbe added a commit that referenced this pull request Jan 13, 2024
* Add Free form data support in SendEvent API (#136)

* Update sendEvent API parameter to accept xdm as well as free form data

* Update tests with the sendEvent API updates

* Update documentation with the freeform data support

* Update sample app with the updated the payload for the sendEvent API changes

* Updates based on reviews

* Added check to validate data is of type map

* some cleanup (#137)

* address review comments

* update the sample code for the sendEvent API

---------

Co-authored-by: Arjun Bhadra <arjun.d.bhadra@gmail.com>
@yangyansong-adbe yangyansong-adbe deleted the cleanup branch January 16, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants