Add Free form data support in SendEvent API#136
Merged
yangyansong-adbe merged 6 commits intoadobe:nonXdmDataSupportfrom Jan 5, 2024
Merged
Add Free form data support in SendEvent API#136yangyansong-adbe merged 6 commits intoadobe:nonXdmDataSupportfrom
yangyansong-adbe merged 6 commits intoadobe:nonXdmDataSupportfrom
Conversation
emdobrin
reviewed
Dec 20, 2023
praveek
reviewed
Dec 21, 2023
praveek
approved these changes
Jan 3, 2024
Contributor
|
@emdobrin I need to add more tests and polish some code. Let me merge this PR for now and create a new PR to the dev or staging branch later. |
yangyansong-adbe
added a commit
that referenced
this pull request
Jan 13, 2024
* Add Free form data support in SendEvent API (#136) * Update sendEvent API parameter to accept xdm as well as free form data * Update tests with the sendEvent API updates * Update documentation with the freeform data support * Update sample app with the updated the payload for the sendEvent API changes * Updates based on reviews * Added check to validate data is of type map * some cleanup (#137) * address review comments * update the sample code for the sendEvent API --------- Co-authored-by: Arjun Bhadra <arjun.d.bhadra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per the internal discussion we decided to make a breaking change and update
sendEventAPI to accept the payload in a different format.Current:
Updated
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: