More tests for events ordering + minor fixes#83
Merged
swarna04 merged 2 commits intoadobe:dev-v4.0.2from Oct 4, 2023
Merged
Conversation
sbenedicadb
approved these changes
Oct 4, 2023
Member
sbenedicadb
left a comment
There was a problem hiding this comment.
looks good pending one request
Sources/AEPOptimize/Optimize.swift
Outdated
|
|
||
| defer { | ||
| // remove completed event's ID from the request event IDs dictionary. | ||
| updateRequestEventIdsInProgress.removeValue(forKey: requestCompletedForEventId) |
Member
There was a problem hiding this comment.
if this method ends up reaching the return on line 248, requestCompletedForEventId will be an empty string and this call doesn't make sense.
let's move this line back to where it was (out of the defer block) so it will only be called when we have an entry to remove.
sbenedicadb
approved these changes
Oct 4, 2023
swarna04
added a commit
that referenced
this pull request
Oct 4, 2023
* Fixed processing order for update/ get events in the extension (#82) * Fix events processing order in the extension. * Added/ updated tests * Incorporated feedback * More tests for events ordering + minor fixes (#83) * More tests + minor fixes * feedback update * Reset in-progress propositions in unexpected scenarios (#85) * More tests + minor fixes * feedback update * Reset in-progress propositions if request eventId is no longer being tracked. * more fixes
swarna04
added a commit
that referenced
this pull request
Oct 5, 2023
* Fixed processing order for update/ get events in the extension (#82) * Fix events processing order in the extension. * Added/ updated tests * Incorporated feedback * More tests for events ordering + minor fixes (#83) * More tests + minor fixes * feedback update * Reset in-progress propositions in unexpected scenarios (#85) * More tests + minor fixes * feedback update * Reset in-progress propositions if request eventId is no longer being tracked. * more fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: