Skip to content

staging to main (v4.0.2)#86

Merged
swarna04 merged 1 commit intomainfrom
staging
Oct 5, 2023
Merged

staging to main (v4.0.2)#86
swarna04 merged 1 commit intomainfrom
staging

Conversation

@swarna04
Copy link
Copy Markdown
Contributor

@swarna04 swarna04 commented Oct 4, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@swarna04
dev to staging (v4.0.2) (#84)
2f980cf 
* Fixed processing order for update/ get events in the extension (#82)

* Fix events processing order in the extension.

* Added/ updated tests

* Incorporated feedback

* More tests for events ordering + minor fixes (#83)

* More tests + minor fixes

* feedback update

* Reset in-progress propositions in unexpected scenarios (#85)

* More tests + minor fixes

* feedback update

* Reset in-progress propositions if request eventId is no longer being tracked.

* more fixes
@swarna04 swarna04 requested a review from sbenedicadb October 4, 2023 22:58
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 4, 2023

Codecov Report

Merging #86 (2f980cf) into main (a5fc10c) will decrease coverage by 0.48%.
The diff coverage is 96.08%.

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   98.45%   97.97%   -0.48%     
==========================================
  Files          13       13              
  Lines         709      838     +129     
==========================================
+ Hits          698      821     +123     
- Misses         11       17       +6
Files Coverage Δ
Sources/AEPOptimize/Array+Optimize.swift 100.00% <100.00%> (ø)
Sources/AEPOptimize/Event+Optimize.swift 100.00% <100.00%> (ø)
Sources/AEPOptimize/Optimize+PublicAPI.swift 93.81% <100.00%> (+0.06%) ⬆️
Sources/AEPOptimize/Optimize.swift 98.16% <95.42%> (-1.84%) ⬇️

@swarna04 swarna04 merged commit ed7219f into main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbenedicadb sbenedicadb sbenedicadb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swarna04 @sbenedicadb