Update Pods when building for XCFramework#211
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #211 +/- ##
=======================================
Coverage 94.30% 94.30%
=======================================
Files 26 26
Lines 913 913
=======================================
Hits 861 861
Misses 52 52 |
praveek
reviewed
Aug 31, 2021
Makefile
Outdated
| make -C SampleApps/$(APP_NAME) build-shallow | ||
|
|
||
| archive: | ||
| bundle exec pod update |
There was a problem hiding this comment.
Can we add the make target pod-update as dependency to archive?
Contributor
Author
There was a problem hiding this comment.
pod-update doesn't use Bundler. However, I can change pod-update to use Bundler instead if that makes sense.
praveek
approved these changes
Sep 1, 2021
kevinlind
added a commit
that referenced
this pull request
Sep 1, 2021
Update Pods when building for XCFramework (#211)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: