Skip to content

Update Pods when building for XCFramework (#211)#212

Merged
kevinlind merged 1 commit intostagingfrom
dev
Sep 1, 2021
Merged

Update Pods when building for XCFramework (#211)#212
kevinlind merged 1 commit intostagingfrom
dev

Conversation

@kevinlind
Copy link
Copy Markdown
Contributor

Description

Merge Dev to Staging, includes changes to Makefile and CI configuration to run pod update before task to build XCFramework.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* Update Pods when building for XCFramework

* Use Bundler when running 'pod update' from 'archive' Makefile target.

* Use Bundler when running 'archive' in CI, but not when running locally
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 1, 2021

Codecov Report

Merging #212 (756f392) into staging (1327121) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           staging     #212   +/-   ##
========================================
  Coverage    94.30%   94.30%           
========================================
  Files           26       26           
  Lines          913      913           
========================================
  Hits           861      861           
  Misses          52       52           

@kevinlind kevinlind requested a review from praveek September 1, 2021 01:59
@kevinlind kevinlind merged commit 74a9812 into staging Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants