dev-v2.0.0 to staging for second 2.0.0-SNAPSHOT#36
Merged
Conversation
Some utils functions have been moved to Core. Refactor to use the Core Utils.
Update using Core Utils
* Update test app instructions and log * Consolidate log tags in test app * Apply lint formatting * Add more context for report suite Fix whitespace issues with headers * Update core registration log text
* Refactor EdgeHitProcessor.processHit to improve error handling * use DataReader when reading location hint scope from response * Add additional unit tests to cover the added error handling. * Add event type in log message when config id is not present * Catch any exceptions thrown from EdgeCallback when completing send event requests * Consolidate creation of EdgeEndpoint code to helper method * Fix typo in test case comment * Add stack trace to logs when an exception is caught in EdgeCallback. * Specify onComplete method name in log warning * use android.util.Log.getStackTrackeString to print stack trace to logs * Check string length instead of catching IndexOutOfBoundsException when processing network response * Pass null for configuration map to EdgeDataEntity in test cases where configuration is empty
Codecov Report
@@ Coverage Diff @@
## staging #36 +/- ##
=============================================
+ Coverage 83.17% 83.28% +0.11%
+ Complexity 380 367 -13
=============================================
Files 29 29
Lines 1545 1555 +10
Branches 219 219
=============================================
+ Hits 1285 1295 +10
Misses 161 161
Partials 99 99
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cacheung
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge dev-v2.0.0 to Staging branch to create second 2.0.0-SNAPSHOT
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: