Skip to content

Update using Core Utils#34

Merged
cacheung merged 1 commit intoadobe:dev-v2.0.0from
cacheung:useCoreUtils
Jan 24, 2023
Merged

Update using Core Utils#34
cacheung merged 1 commit intoadobe:dev-v2.0.0from
cacheung:useCoreUtils

Conversation

@cacheung
Copy link
Copy Markdown
Contributor

@cacheung cacheung commented Jan 21, 2023

Some utils functions have been moved to Core. Refactor to use the Core Utils.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cacheung
Update using Core Utils
af95644 
Some utils functions have been moved to Core.  Refactor to use the Core Utils.
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2023 •
edited
Loading

Codecov Report

Merging #34 (af95644) into dev-v2.0.0 (31fe7e6) will decrease coverage by 0.12%.
The diff coverage is 75.00%.

@@               Coverage Diff                @@
##             dev-v2.0.0      #34      +/-   ##
================================================
- Coverage         83.17%   83.05%   -0.12%     
+ Complexity          380      361      -19     
================================================
  Files                29       29              
  Lines              1545     1534      -11     
  Branches            219      217       -2     
================================================
- Hits               1285     1274      -11     
  Misses              161      161              
  Partials             99       99
Flag Coverage Δ
functional-tests 66.17% <50.00%> (+0.02%) ⬆️
unit-tests 79.07% <71.88%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/main/java/com/adobe/marketing/mobile/Utils.java 93.55% <ø> (-1.69%) ⬇️
...adobe/marketing/mobile/NetworkResponseHandler.java 82.14% <28.57%> (ø)
...src/main/java/com/adobe/marketing/mobile/Edge.java 60.87% <50.00%> (ø)
.../com/adobe/marketing/mobile/EdgeConsentUpdate.java 81.48% <75.00%> (ø)
...ava/com/adobe/marketing/mobile/RequestBuilder.java 84.00% <80.00%> (ø)
...java/com/adobe/marketing/mobile/EdgeExtension.java 85.26% <100.00%> (ø)
...n/java/com/adobe/marketing/mobile/EdgeRequest.java 71.43% <100.00%> (ø)
...ain/java/com/adobe/marketing/mobile/EdgeState.java 98.41% <100.00%> (ø)
...in/java/com/adobe/marketing/mobile/EventUtils.java 87.50% <100.00%> (ø)
...va/com/adobe/marketing/mobile/ExperienceEvent.java 80.49% <100.00%> (ø)
... and 3 more

@emdobrin emdobrin linked an issue Jan 23, 2023 that may be closed by this pull request
Use Utils from Core #25
Closed
@cacheung cacheung merged commit 57084be into adobe:dev-v2.0.0 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emdobrin emdobrin emdobrin approved these changes

@kevinlind kevinlind Awaiting requested review from kevinlind

@addb addb Awaiting requested review from addb

@timkimadobe timkimadobe Awaiting requested review from timkimadobe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use Utils from Core

2 participants

@cacheung @emdobrin