Update test app logging service and instruction text#29
Merged
timkimadobe merged 5 commits intoadobe:dev-v2.0.0from Jan 24, 2023
Merged
Update test app logging service and instruction text#29timkimadobe merged 5 commits intoadobe:dev-v2.0.0from
timkimadobe merged 5 commits intoadobe:dev-v2.0.0from
Conversation
Codecov Report
@@ Coverage Diff @@
## dev-v2.0.0 #29 +/- ##
=============================================
Coverage 83.17% 83.17%
Complexity 380 380
=============================================
Files 29 29
Lines 1545 1545
Branches 219 219
=============================================
Hits 1285 1285
Misses 161 161
Partials 99 99
Flags with carried forward coverage won't be shown. Click here to find out more. |
kevinlind
reviewed
Jan 18, 2023
| public class TestApplication extends Application { | ||
|
|
||
| private static final String LOG_TAG = "TestApplication"; | ||
| private static final String LOG_TAG = "EdgeTestApplication"; |
Contributor
There was a problem hiding this comment.
MainActivity is using LOG_TAG = "TestApp". Can you consolidate the two? Maybe rename to "EdgeTestApp", make public static final and then static import this LOG_TAG into MainActivity?
Contributor
Author
|
Thanks for the review @kevinlind! I've updated the test app log tags accordingly |
emdobrin
approved these changes
Jan 19, 2023
addb
reviewed
Jan 24, 2023
| MobileCore.registerExtensions( | ||
| Arrays.asList(Edge.EXTENSION, Identity.EXTENSION, Consent.EXTENSION, Assurance.EXTENSION), | ||
| o -> Log.d(LOG_TAG, "Mobile SDK was initialized") | ||
| o -> Log.debug(LOG_TAG, LOG_SOURCE, "Mobile SDK was initialized") |
Contributor
There was a problem hiding this comment.
nit: Should we reword it to something like AEP Mobile SDK initialized
Contributor
Author
There was a problem hiding this comment.
Thank you! I think that sounds good, I've updated the log text to the suggested version
Fix whitespace issues with headers
addb
approved these changes
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Edge test app to use the Core 2.0 logging service and some instruction/comment text
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: