PathItem Fix#262
Merged
sebbader-sap merged 3 commits intoIDTA-01002-3-0_bugfix-2-preparationfrom Mar 19, 2024
Merged
Conversation
Contributor
Author
|
Additional reviews are welcome... |
mjacoby
reviewed
Mar 19, 2024
Part2-API-Schemas/openapi.yaml
Outdated
| PathItem: | ||
| type: string | ||
| pattern: "^(([A-Za-z][A-Za-z0-9_]+)|(\\[[0-9]+\\]))((\\.[A-Za-z][A-Za-z0-9_]+)|(\\[[0-9]+\\])){0,}$" | ||
| pattern: "^([A-Za-z][A-Za-z0-9_]+)((\\.[A-Za-z][A-Za-z0-9_]+)|(\\[[0-9]+\\])){0,}$" |
Collaborator
There was a problem hiding this comment.
Seems quite solid to me. Only small issue I see is that it allows for leading zeros in array indicies, e.g. foo[0000] or foo[00000000000000000000000001] are considered valid. Not sure if this is intentional but I would suggest to not allow this as it can easily be fixed by using ^([A-Za-z][A-Za-z0-9_]+)((\\.[A-Za-z][A-Za-z0-9_]+)|(\\[(0|[1-9][0-9]*)\\])){0,}$ instead
mjacoby
approved these changes
Mar 19, 2024
sebbader-sap
added a commit
that referenced
this pull request
Jul 3, 2024
* fix metadata and path endpoints * increase the version to the v3.0.2 bugfix version * remove bytes * remove "submodelElements" from SubmodelValue * Replace Service Description Profiles Enum with an open List (#230) * change servicedescription/profiles enum to an open list, providing predefined values only as examples * Remove Level from /$metadata (#250) * remove the Level modifier from $metadata requests * remove allOf SubmodelElementAttributes from SubmodelElementMetadata * fix ValueOnly description * PathItem Fix (#262) add array<pathitem> where missing + new pathitem regex * fix the regex pattern for part 2 classes according to the JSON schema regex (#256) * fix bugs in the valueonly classes * change annotations from array to value only * replace regex patterns with latest json schema v3.0.1 content * using the new string regex pattern also for part 2 classes --------- Co-authored-by: Alexander Gordt <100141498+alexgordtop@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #258