Skip to content

Remove Level from /$metadata#250

Merged
sebbader-sap merged 3 commits intoIDTA-01002-3-0_bugfix-2-preparationfrom
SeBa/249-fix-metadata
Mar 12, 2024
Merged

Remove Level from /$metadata#250
sebbader-sap merged 3 commits intoIDTA-01002-3-0_bugfix-2-preparationfrom
SeBa/249-fix-metadata

Conversation

@sebbader-sap
Copy link
Contributor

Solves #249

@sebbader-sap sebbader-sap added this to the 3.0.2 milestone Mar 3, 2024
Copy link
Collaborator

@BirgitBoss BirgitBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebbader-sap
Copy link
Contributor Author

SwaggerHub is not synched yet. Will do after this and a few other OpenAPI-related PRs are merged.

@BirgitBoss
Copy link
Collaborator

SwaggerHub is not synched yet. Will do after this and a few other OpenAPI-related PRs are merged.

same for .yml I would say

@mjacoby
Copy link
Collaborator

mjacoby commented Mar 5, 2024

@BirgitBoss I just did a detailed review and could not find anything wrong in the *.yaml files. If you still think there is something wrong, please provide an inline comment at the concrete position, otherwise update your review to "accept" so that @sebbader-sap can merge

Copy link
Collaborator

@BirgitBoss BirgitBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not find any errors

@sebbader-sap sebbader-sap merged commit 1ccb652 into IDTA-01002-3-0_bugfix-2-preparation Mar 12, 2024
@sebbader-sap sebbader-sap deleted the SeBa/249-fix-metadata branch March 12, 2024 09:27
sebbader-sap added a commit that referenced this pull request Jul 3, 2024
* fix metadata and path endpoints

* increase the version to the v3.0.2 bugfix version

* remove bytes

* remove "submodelElements" from SubmodelValue

* Replace Service Description Profiles Enum with an open List (#230)

* change servicedescription/profiles enum to an open list, providing predefined values only as examples

* Remove Level from /$metadata (#250)

* remove the Level modifier from $metadata requests

* remove allOf SubmodelElementAttributes from SubmodelElementMetadata

* fix ValueOnly description

* PathItem Fix (#262)

add array<pathitem> where missing + new pathitem regex

* fix the regex pattern for part 2 classes according to the JSON schema regex (#256)

* fix bugs in the valueonly classes

* change annotations from array to value only

* replace regex patterns with latest json schema v3.0.1 content

* using the new string regex pattern also for part 2 classes

---------

Co-authored-by: Alexander Gordt <100141498+alexgordtop@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants