Skip to content

General bugfixes#266

Merged
actuallymentor merged 11 commits intoactuallymentor:mainfrom
Chr1s70ph:general_bugfixes
Jun 28, 2024
Merged

General bugfixes#266
actuallymentor merged 11 commits intoactuallymentor:mainfrom
Chr1s70ph:general_bugfixes

Conversation

@Chr1s70ph
Copy link
Copy Markdown
Contributor

@Chr1s70ph Chr1s70ph commented Apr 21, 2024

Continues the work of #253

  • Fix multiple running of enable_charging
  • Fix battery not found if not running in $PATH
  • Fix not charging when disabeling limit
  • Fixes validation of battery percentages
  • Fix MagSafe charging colors
  • Add more logging

I believe this fixes all the broken functions. Let me know if there is anything else I missed.

@actuallymentor
Copy link
Copy Markdown
Owner

I really appreciate these bugfixes Chris!

Could you increment the version number in battery.sh? It is used to trigger updates.

@actuallymentor
Copy link
Copy Markdown
Owner

Actually, don't worry about it. I'll do it manually.

Thank you very much for your work!

@actuallymentor actuallymentor merged commit bafebb7 into actuallymentor:main Jun 28, 2024
@Chr1s70ph Chr1s70ph deleted the general_bugfixes branch June 29, 2024 12:03
panoskava pushed a commit to panoskava/battery that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants