Merged
Conversation
mihaiconstantin
commented
Apr 13, 2022
Contributor
Author
mihaiconstantin
left a comment
There was a problem hiding this comment.
Fixed in 5100905.
|
You didn't handle the case in which the user might have run visudo. Might need to revert the changes done by visudo. |
Contributor
Author
Good point. I am erring on the side of caution since I don't really know how |
Owner
|
Thank you for the contribution @mihaiconstantin! One small addition request, could you increment the Then I'll merge it :) |
Contributor
Author
|
@actuallymentor, awesome! I see the following:
I incremented in both places to |
Owner
|
Thank you for the contribution! |
Chr1s70ph
pushed a commit
to Chr1s70ph/battery
that referenced
this pull request
Apr 21, 2024
Apply accuracy-fix changes to bugfixes
panoskava
pushed a commit
to panoskava/battery
that referenced
this pull request
Mar 17, 2026
…mmand Add uninstall action
panoskava
pushed a commit
to panoskava/battery
that referenced
this pull request
Mar 17, 2026
Apply accuracy-fix changes to bugfixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a simple action to uninstall the
smctool and thebatteryscript (i.e., partially addressing #1). From what I understand of thesetup.shscripts, the steps required to uninstall this utility are:smcandbatteryfrom/usr/local/binI am not entirely sure about (1), but I suppose this boils down to setting the
CH0BandCH0Ckeys back to00? Or is there another way to reset these keys to their corresponding defaults?